Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TDR-3364 - Create API Gateway resource #24

Merged
merged 2 commits into from
Sep 13, 2023
Merged

TDR-3364 - Create API Gateway resource #24

merged 2 commits into from
Sep 13, 2023

Conversation

thanhz
Copy link
Contributor

@thanhz thanhz commented Sep 12, 2023

No description provided.

TomJKing
TomJKing reviewed Sep 13, 2023
View reviewed changes
Copy link
Contributor

@TomJKing TomJKing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks. Just a couple of very minor comments.

terraform/root_main.tf Outdated Show resolved Hide resolved
terraform/root_main.tf Outdated Show resolved Hide resolved
@thanhz thanhz requested a review from TomJKing September 13, 2023 09:30
TomJKing
TomJKing approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@TomJKing TomJKing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks

@thanhz thanhz merged commit eccaa1a into main Sep 13, 2023
4 checks passed
@thanhz thanhz deleted the TDR-3364_create_api_gateway branch September 13, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomJKing TomJKing TomJKing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thanhz @TomJKing