diff --git a/src/caselawclient/models/neutral_citation_mixin.py b/src/caselawclient/models/neutral_citation_mixin.py index 7f5c38df..99e2976d 100644 --- a/src/caselawclient/models/neutral_citation_mixin.py +++ b/src/caselawclient/models/neutral_citation_mixin.py @@ -23,11 +23,6 @@ class NeutralCitationMixin(ABC): def __init__(self, document_noun: str, *args: Any, **kwargs: Any) -> None: self.attributes_to_validate: list[tuple[str, bool, str]] = self.attributes_to_validate + [ - ( - "has_ncn", - True, - f"This {document_noun} has no neutral citation number", - ), ( "has_valid_ncn", True, @@ -42,11 +37,6 @@ def __init__(self, document_noun: str, *args: Any, **kwargs: Any) -> None: @deprecated("Legacy usage of NCNs is deprecated; you should be moving to the Identifiers framework") def neutral_citation(self) -> Optional[NeutralCitationString]: ... - @cached_property - @deprecated("Legacy usage of NCNs is deprecated; you should be moving to the Identifiers framework") - def has_ncn(self) -> bool: - return self.neutral_citation is not None and self.neutral_citation != "" - @cached_property @deprecated("Legacy usage of NCNs is deprecated; you should be moving to the Identifiers framework") def has_valid_ncn(self) -> bool: diff --git a/tests/models/test_judgments.py b/tests/models/test_judgments.py index af43bb2f..12c49658 100644 --- a/tests/models/test_judgments.py +++ b/tests/models/test_judgments.py @@ -7,7 +7,6 @@ from caselawclient.models.documents import DocumentURIString from caselawclient.models.identifiers.neutral_citation import NeutralCitationNumber from caselawclient.models.judgments import Judgment -from caselawclient.models.neutral_citation_mixin import NeutralCitationString class TestJudgment: @@ -19,16 +18,6 @@ def test_best_identifier(self, mock_api_client): class TestJudgmentValidation: - def test_has_ncn(self, mock_api_client): - document_with_ncn = Judgment(DocumentURIString("test/1234"), mock_api_client) - document_with_ncn.neutral_citation = NeutralCitationString("[2023] TEST 1234") - - document_without_ncn = Judgment(DocumentURIString("test/1234"), mock_api_client) - document_without_ncn.neutral_citation = NeutralCitationString("") - - assert document_with_ncn.has_ncn is True - assert document_without_ncn.has_ncn is False - def test_judgment_neutral_citation(self, mock_api_client): mock_api_client.get_judgment_xml_bytestring.return_value = b"""