Skip to content

Commit

Permalink
Remove font-display
Browse files Browse the repository at this point in the history
  • Loading branch information
ahosgood committed Oct 18, 2023
1 parent 11a4b75 commit 113798b
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
4 changes: 2 additions & 2 deletions .storybook/preview-head.html
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
document.addEventListener("DOMContentLoaded", removeAllClasses, false);
}
</script>
<link
<!-- <link
rel="preload"
href="/static/media/src/nationalarchives/assets/fonts/OpenSans-Medium.ttf"
as="font"
Expand Down Expand Up @@ -62,4 +62,4 @@
as="font"
type="font/woff2"
crossorigin="anonymous"
/>
/> -->
1 change: 0 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- Breadcrumbs are no longer contained within a container/column layout
- Header styles have been simplified
- Fonts now use `font-display` to avoid blocking rendering
- External link icons changed from CSS to icon font in header and footer
- External links in footer have titles suffixed with "opens in new tab"
- Links in footer and text in buttons have balanced wrapping applied
Expand Down
6 changes: 3 additions & 3 deletions src/nationalarchives/utilities/_typography.scss
Original file line number Diff line number Diff line change
Expand Up @@ -14,23 +14,23 @@
src: url("#{assets.$tna-font-path}/OpenSans-Medium.ttf") format("ttf");
font-weight: normal;
font-style: normal;
font-display: swap;
// font-display: swap;
}

@font-face {
font-family: "Open Sans";
src: url("#{assets.$tna-font-path}/OpenSans-Bold.ttf") format("ttf");
font-weight: bold;
font-style: normal;
font-display: swap;
// font-display: swap;
}

@font-face {
font-family: "Roboto Mono";
src: url("#{assets.$tna-font-path}/RobotoMono-Regular.ttf") format("ttf");
font-weight: normal;
font-style: normal;
font-display: swap;
// font-display: swap;
}

.tna-template {
Expand Down

0 comments on commit 113798b

Please sign in to comment.