From 378273de2baee1656450cd390c0bf60ecca8b86a Mon Sep 17 00:00:00 2001 From: Andrew Hosgood Date: Fri, 1 Mar 2024 18:11:35 +0000 Subject: [PATCH] Fix global header links --- .../global-header/global-header.stories.js | 52 ++++++++++++------- .../generate-global-header-assets.js | 18 ++++--- 2 files changed, 44 insertions(+), 26 deletions(-) diff --git a/src/nationalarchives/components/global-header/global-header.stories.js b/src/nationalarchives/components/global-header/global-header.stories.js index 2cce2f7a..584a73f5 100644 --- a/src/nationalarchives/components/global-header/global-header.stories.js +++ b/src/nationalarchives/components/global-header/global-header.stories.js @@ -69,10 +69,13 @@ Standard.args = { }, ], navigation: [ - { text: "Visit", href: "www.nationalarchives.gov.uk/about/visit-us/" }, + { + text: "Visit", + href: "https://www.nationalarchives.gov.uk/about/visit-us/", + }, { text: "What's on", - href: "www.nationalarchives.gov.uk/about/visit-us/whats-on/", + href: "https://www.nationalarchives.gov.uk/about/visit-us/whats-on/", }, { text: "Explore the collection", @@ -80,12 +83,12 @@ Standard.args = { }, { text: "Using the archive", - href: "www.nationalarchives.gov.uk/help-with-your-research/", + href: "https://www.nationalarchives.gov.uk/help-with-your-research/", }, - { text: "Learn", href: "www.nationalarchives.gov.uk/education/" }, + { text: "Learn", href: "https://www.nationalarchives.gov.uk/education/" }, { text: "Professional guidance and services", - href: "www.nationalarchives.gov.uk/professional-guidance-and-services/", + href: "https://www.nationalarchives.gov.uk/professional-guidance-and-services/", }, ], classes: "tna-global-header--demo", @@ -136,10 +139,13 @@ Medium.args = { }, ], navigation: [ - { text: "Visit", href: "www.nationalarchives.gov.uk/about/visit-us/" }, + { + text: "Visit", + href: "https://www.nationalarchives.gov.uk/about/visit-us/", + }, { text: "What's on", - href: "www.nationalarchives.gov.uk/about/visit-us/whats-on/", + href: "https://www.nationalarchives.gov.uk/about/visit-us/whats-on/", }, { text: "Explore the collection", @@ -147,12 +153,12 @@ Medium.args = { }, { text: "Using the archive", - href: "www.nationalarchives.gov.uk/help-with-your-research/", + href: "https://www.nationalarchives.gov.uk/help-with-your-research/", }, - { text: "Learn", href: "www.nationalarchives.gov.uk/education/" }, + { text: "Learn", href: "https://www.nationalarchives.gov.uk/education/" }, { text: "Professional guidance and services", - href: "www.nationalarchives.gov.uk/professional-guidance-and-services/", + href: "https://www.nationalarchives.gov.uk/professional-guidance-and-services/", }, ], classes: "tna-global-header--demo", @@ -203,10 +209,13 @@ MediumCollapsed.args = { }, ], navigation: [ - { text: "Visit", href: "www.nationalarchives.gov.uk/about/visit-us/" }, + { + text: "Visit", + href: "https://www.nationalarchives.gov.uk/about/visit-us/", + }, { text: "What's on", - href: "www.nationalarchives.gov.uk/about/visit-us/whats-on/", + href: "https://www.nationalarchives.gov.uk/about/visit-us/whats-on/", }, { text: "Explore the collection", @@ -214,12 +223,12 @@ MediumCollapsed.args = { }, { text: "Using the archive", - href: "www.nationalarchives.gov.uk/help-with-your-research/", + href: "https://www.nationalarchives.gov.uk/help-with-your-research/", }, - { text: "Learn", href: "www.nationalarchives.gov.uk/education/" }, + { text: "Learn", href: "https://www.nationalarchives.gov.uk/education/" }, { text: "Professional guidance and services", - href: "www.nationalarchives.gov.uk/professional-guidance-and-services/", + href: "https://www.nationalarchives.gov.uk/professional-guidance-and-services/", }, ], collapseOnMedium: true, @@ -258,10 +267,13 @@ Mobile.args = { }, ], navigation: [ - { text: "Visit", href: "www.nationalarchives.gov.uk/about/visit-us/" }, + { + text: "Visit", + href: "https://www.nationalarchives.gov.uk/about/visit-us/", + }, { text: "What's on", - href: "www.nationalarchives.gov.uk/about/visit-us/whats-on/", + href: "https://www.nationalarchives.gov.uk/about/visit-us/whats-on/", }, { text: "Explore the collection", @@ -269,12 +281,12 @@ Mobile.args = { }, { text: "Using the archive", - href: "www.nationalarchives.gov.uk/help-with-your-research/", + href: "https://www.nationalarchives.gov.uk/help-with-your-research/", }, - { text: "Learn", href: "www.nationalarchives.gov.uk/education/" }, + { text: "Learn", href: "https://www.nationalarchives.gov.uk/education/" }, { text: "Professional guidance and services", - href: "www.nationalarchives.gov.uk/professional-guidance-and-services/", + href: "https://www.nationalarchives.gov.uk/professional-guidance-and-services/", }, ], classes: "tna-global-header--demo", diff --git a/tasks/global-header/generate-global-header-assets.js b/tasks/global-header/generate-global-header-assets.js index 13da7721..17d2fb1b 100644 --- a/tasks/global-header/generate-global-header-assets.js +++ b/tasks/global-header/generate-global-header-assets.js @@ -13,7 +13,7 @@ const globalHeaderHTML = nunjucks .renderString(globalHeaderComponentNunjucks, { params: { logo: { - href: "https://nationalarchives.gov.uk/", + href: "https://www.nationalarchives.gov.uk/", }, topNavigation: [ { @@ -33,10 +33,13 @@ const globalHeaderHTML = nunjucks // }, ], navigation: [ - { text: "Visit", href: "www.nationalarchives.gov.uk/about/visit-us/" }, + { + text: "Visit", + href: "https://www.nationalarchives.gov.uk/about/visit-us/", + }, { text: "What's on", - href: "www.nationalarchives.gov.uk/about/visit-us/whats-on/", + href: "https://www.nationalarchives.gov.uk/about/visit-us/whats-on/", }, { text: "Explore the collection", @@ -44,12 +47,15 @@ const globalHeaderHTML = nunjucks }, { text: "Using the archive", - href: "www.nationalarchives.gov.uk/help-with-your-research/", + href: "https://www.nationalarchives.gov.uk/help-with-your-research/", + }, + { + text: "Learn", + href: "https://www.nationalarchives.gov.uk/education/", }, - { text: "Learn", href: "www.nationalarchives.gov.uk/education/" }, { text: "Professional guidance and services", - href: "www.nationalarchives.gov.uk/professional-guidance-and-services/", + href: "https://www.nationalarchives.gov.uk/professional-guidance-and-services/", }, ], },