From 61310d9bd8c0ccff711d3407cb172467b5dbe9c1 Mon Sep 17 00:00:00 2001 From: Andrew Hosgood Date: Thu, 16 Nov 2023 16:52:21 +0000 Subject: [PATCH] Fix release workflow --- .github/workflows/npm-publish.yml | 9 +++------ .gitignore | 3 ++- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/.github/workflows/npm-publish.yml b/.github/workflows/npm-publish.yml index 0cdacec0..1eb9dc94 100644 --- a/.github/workflows/npm-publish.yml +++ b/.github/workflows/npm-publish.yml @@ -1,4 +1,4 @@ -name: Publish new release +name: Publish release on: release: @@ -99,14 +99,11 @@ jobs: - uses: actions/checkout@v3 - name: Get release notes id: get-release-notes - run: | - RELEASE_NOTES=$(./tasks/get-release-notes.sh "${{ needs.check.outputs.version }}") - echo $RELEASE_NOTES - echo "RELEASE_NOTES=$RELEASE_NOTES" >> "$GITHUB_OUTPUT" + run: ./tasks/get-release-notes.sh "${{ needs.check.outputs.version }}" > RELEASE_NOTES.txt - uses: rtCamp/action-slack-notify@v2 env: SLACK_TITLE: "`v${{ needs.check.outputs.version }}` of `tna-frontend` has just been published" SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }} SLACK_ICON: "https://raw.githubusercontent.com/nationalarchives/tna-frontend/main/src/nationalarchives/assets/images/apple-touch-icon.png" MSG_MINIMAL: true - SLACK_MESSAGE: ${{ env.RELEASE_NOTES }} + SLACK_MESSAGE: $(cat RELEASE_NOTES.txt) diff --git a/.gitignore b/.gitignore index bc409558..b4688170 100644 --- a/.gitignore +++ b/.gitignore @@ -8,4 +8,5 @@ storybook *.tgz build-storybook.log chromatic.config.json -chromatic.log \ No newline at end of file +chromatic.log +RELEASE_NOTES.txt \ No newline at end of file