Skip to content

Commit

Permalink
Spacing tweaks (#25)
Browse files Browse the repository at this point in the history
* Adjust spacing on hero mobile view

* Remove vertical spacing on <hr>

* Update CHANGELOG.md

* Add tna-button-group around button in footer

* Fix <hr> double border
  • Loading branch information
ahosgood authored Oct 23, 2023
1 parent 9e27de9 commit 77c1764
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 31 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Links in footer and text in buttons have balanced wrapping applied
- Header and header group class modifiers have been moved to separate blocks (`tna-heading tna-heading--xl` -> `tna-heading-xl`)
- `space-below` has been replaced with `space-above` and all paddings in between page elements reassessed
- Tweak spacing on hero component and `<hr>` elements
- Added `tna-button-group` around newletter subscription button in the footer
- Updated Storybook to `7.5.1`

### Deprecated
Expand Down
10 changes: 6 additions & 4 deletions src/nationalarchives/components/footer/template.njk
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,12 @@
<p>
Subscribe for regular news, updates and priority booking for events.
</p>
<a href="#" class="tna-button tna-button--accent" role="button">
<i class="fa-solid fa-envelope"></i>
Subscribe
</a>
<div class="tna-button-group">
<a href="#" class="tna-button tna-button--accent" role="button">
<i class="fa-solid fa-envelope"></i>
Subscribe
</a>
</div>
</div>
</div>
{%- endif -%}
Expand Down
2 changes: 1 addition & 1 deletion src/nationalarchives/components/hero/hero.scss
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@
}

&__content-inner {
padding: 1.5rem 0;
padding: 2rem 0;

background-color: transparent;
}
Expand Down
25 changes: 0 additions & 25 deletions src/nationalarchives/stories/design/about.mdx

This file was deleted.

2 changes: 1 addition & 1 deletion src/nationalarchives/utilities/_global.scss
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ canvas {
}

hr {
margin: 2rem 0;
margin: 0;

border-width: 1px 0 0;
@include colour.colour-border("keyline");
Expand Down

0 comments on commit 77c1764

Please sign in to comment.