From bda73ad5b891ceb5f9870429a3923ad500cdd88d Mon Sep 17 00:00:00 2001
From: Andrew Hosgood <andrew.hosgood@nationalarchives.gov.uk>
Date: Thu, 25 Jul 2024 13:22:50 +0100
Subject: [PATCH] Fix button typeface and remove :link selectors

---
 CHANGELOG.md                                                | 4 ++++
 .../components/breadcrumbs/breadcrumbs.scss                 | 2 --
 src/nationalarchives/components/button/button.scss          | 6 +-----
 .../components/error-summary/error-summary.scss             | 1 -
 .../components/global-header/global-header.scss             | 3 ---
 src/nationalarchives/components/header/header.scss          | 6 ------
 src/nationalarchives/components/index-grid/index-grid.scss  | 1 -
 .../components/quick-filters/quick-filters.scss             | 2 --
 src/nationalarchives/components/skip-link/skip-link.scss    | 1 -
 src/nationalarchives/components/tabs/tabs.scss              | 1 -
 src/nationalarchives/global-header-package.scss             | 2 --
 11 files changed, 5 insertions(+), 24 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index c80a672c..92c378c0 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -14,9 +14,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Deprecated
 ### Removed
+
+- Removed styling for links with the `:link` pseudo class - all `<a>` elements should posess an `href` attribute by default
+
 ### Fixed
 
 - Further fixed gallery component layout when CSS loads but JS fails
+- Buttons using the `<button>` element now have the correct typeface (they were using the browser default)
 
 ### Security
 
diff --git a/src/nationalarchives/components/breadcrumbs/breadcrumbs.scss b/src/nationalarchives/components/breadcrumbs/breadcrumbs.scss
index 6de8282e..db06f8fe 100644
--- a/src/nationalarchives/components/breadcrumbs/breadcrumbs.scss
+++ b/src/nationalarchives/components/breadcrumbs/breadcrumbs.scss
@@ -50,7 +50,6 @@
     display: inline-block;
 
     &,
-    &:link,
     &:visited {
       @include colour.colour-font("font-base");
     }
@@ -94,7 +93,6 @@
   @include colour.on-high-contrast {
     &__link {
       &,
-      &:link,
       &:visited {
         @include colour.colour-font("link");
       }
diff --git a/src/nationalarchives/components/button/button.scss b/src/nationalarchives/components/button/button.scss
index 91df9a68..362c9334 100644
--- a/src/nationalarchives/components/button/button.scss
+++ b/src/nationalarchives/components/button/button.scss
@@ -23,7 +23,7 @@ $button-border-width: 4px !default;
   cursor: pointer;
 
   @include typography.font-size(18);
-  @include typography.main-font-weight-bold;
+  @include typography.main-font(true);
 
   @include colour.colour-background("button-background");
 
@@ -33,7 +33,6 @@ $button-border-width: 4px !default;
   print-color-adjust: exact;
 
   &,
-  &:link,
   &:visited {
     @include colour.colour-font("button-text");
   }
@@ -69,7 +68,6 @@ $button-border-width: 4px !default;
     border-color: transparent;
 
     &,
-    &:link,
     &:visited {
       @include colour.colour-font("link");
     }
@@ -90,7 +88,6 @@ $button-border-width: 4px !default;
     @include colour.colour-border("button-accented-background");
 
     &,
-    &:link,
     &:visited {
       @include colour.colour-font("button-accented-text");
     }
@@ -192,7 +189,6 @@ $button-border-width: 4px !default;
     @include colour.colour-border("button-background");
 
     &,
-    &:link,
     &:visited {
       @include colour.colour-font("button-text");
     }
diff --git a/src/nationalarchives/components/error-summary/error-summary.scss b/src/nationalarchives/components/error-summary/error-summary.scss
index 702fe529..a090261b 100644
--- a/src/nationalarchives/components/error-summary/error-summary.scss
+++ b/src/nationalarchives/components/error-summary/error-summary.scss
@@ -30,7 +30,6 @@
     @include typography.main-font-weight-bold;
 
     &,
-    &:link,
     &:visited {
       @include colour.colour-font("form-error-text");
     }
diff --git a/src/nationalarchives/components/global-header/global-header.scss b/src/nationalarchives/components/global-header/global-header.scss
index 63a3832f..15d1e498 100644
--- a/src/nationalarchives/components/global-header/global-header.scss
+++ b/src/nationalarchives/components/global-header/global-header.scss
@@ -46,7 +46,6 @@
 
     &--link {
       &,
-      &:link,
       &:visited {
         @include colour.colour-font("font-base");
       }
@@ -185,7 +184,6 @@
     @include colour.colour-border("keyline", 0.5px, solid, bottom);
 
     &,
-    &:link,
     &:visited {
       @include colour.colour-font("font-base");
     }
@@ -217,7 +215,6 @@
     text-decoration: none;
 
     &,
-    &:link,
     &:visited {
       @include colour.colour-font("font-light");
     }
diff --git a/src/nationalarchives/components/header/header.scss b/src/nationalarchives/components/header/header.scss
index f4762ad4..d1e7d89a 100644
--- a/src/nationalarchives/components/header/header.scss
+++ b/src/nationalarchives/components/header/header.scss
@@ -40,7 +40,6 @@
     @include typography.font-size(16);
 
     &,
-    &:link,
     &:visited {
       @include colour.colour-font("font-base");
     }
@@ -74,7 +73,6 @@
 
     &--link {
       &,
-      &:link,
       &:visited {
         color: inherit;
       }
@@ -220,7 +218,6 @@
     text-decoration: none;
 
     &,
-    &:link,
     &:visited {
       @include colour.colour-font("font-light");
     }
@@ -228,7 +225,6 @@
     &:hover,
     &--selected {
       &,
-      &:link,
       &:visited {
         @include colour.colour-font("font-base");
         @include typography.interacted-text-decoration;
@@ -282,7 +278,6 @@
     }
 
     &,
-    &:link,
     &:visited {
       color: inherit;
     }
@@ -362,7 +357,6 @@
 
     &__top-navigation-item-link {
       &,
-      &:link,
       &:visited {
         @include colour.colour-font("font-light");
       }
diff --git a/src/nationalarchives/components/index-grid/index-grid.scss b/src/nationalarchives/components/index-grid/index-grid.scss
index 58dbec2a..7899188d 100644
--- a/src/nationalarchives/components/index-grid/index-grid.scss
+++ b/src/nationalarchives/components/index-grid/index-grid.scss
@@ -64,7 +64,6 @@
 
     .tna-index-grid__item:hover & {
       &,
-      &:link,
       &:visited {
         @include typography.interacted-text-decoration;
       }
diff --git a/src/nationalarchives/components/quick-filters/quick-filters.scss b/src/nationalarchives/components/quick-filters/quick-filters.scss
index e3028522..40323db1 100644
--- a/src/nationalarchives/components/quick-filters/quick-filters.scss
+++ b/src/nationalarchives/components/quick-filters/quick-filters.scss
@@ -46,7 +46,6 @@
     @include colour.colour-border("keyline", 1px);
 
     &,
-    &:link,
     &:visited {
       @include colour.colour-font("font-base");
     }
@@ -58,7 +57,6 @@
 
   &__item--selected &__link {
     &,
-    &:link,
     &:visited,
     &:hover {
       @include colour.accent;
diff --git a/src/nationalarchives/components/skip-link/skip-link.scss b/src/nationalarchives/components/skip-link/skip-link.scss
index 5ac4b43e..b75f3c17 100644
--- a/src/nationalarchives/components/skip-link/skip-link.scss
+++ b/src/nationalarchives/components/skip-link/skip-link.scss
@@ -25,7 +25,6 @@
   clip-path: inset(50%) !important;
 
   &,
-  &:link,
   &:visited {
     @include colour.colour-font("button-text", $important: true);
   }
diff --git a/src/nationalarchives/components/tabs/tabs.scss b/src/nationalarchives/components/tabs/tabs.scss
index 3377ccdf..5bd97cdb 100644
--- a/src/nationalarchives/components/tabs/tabs.scss
+++ b/src/nationalarchives/components/tabs/tabs.scss
@@ -43,7 +43,6 @@
     @include typography.heading-font;
 
     &,
-    &:link,
     &:visited {
       @include colour.colour-font("font-dark");
     }
diff --git a/src/nationalarchives/global-header-package.scss b/src/nationalarchives/global-header-package.scss
index dddd203a..e5303c98 100644
--- a/src/nationalarchives/global-header-package.scss
+++ b/src/nationalarchives/global-header-package.scss
@@ -160,7 +160,6 @@ hr {
 
 .tna-button {
   &,
-  &:link,
   &:visited {
     text-decoration: none;
   }
@@ -182,7 +181,6 @@ hr {
 
       &-link {
         &,
-        &:link,
         &:visited {
           display: block;
         }