From db9b6a283713ae1748718aef158c6d0346ab97b2 Mon Sep 17 00:00:00 2001
From: Andrew Hosgood <mail@andrewhosgood.com>
Date: Fri, 19 Jul 2024 16:46:45 +0100
Subject: [PATCH] Tweaks and fixes from v0.2.1 (#151)

* Allow the arrows to appear on card heading links, fix padding on cards

* Remove whitespace from warning component

* Remove visited link colour from heading links with tna-link--no-visited-state

* Update CHANGELOG.md
---
 CHANGELOG.md                                          | 8 ++++++++
 src/nationalarchives/components/card/card.scss        | 7 +------
 src/nationalarchives/components/warning/template.njk  | 3 +--
 src/nationalarchives/utilities/typography/_index.scss | 2 +-
 4 files changed, 11 insertions(+), 9 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 62bd5448..459ac50d 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -9,9 +9,17 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Added
 ### Changed
+
+- Allowed the arrows to appear on card heading links
+
 ### Deprecated
 ### Removed
 ### Fixed
+
+- Arrow colour for visited heading links with the class `tna-link--no-visited-state`
+- Incorrect padding on the bottom of horizontal cards
+- Removed space between heading and exclamation mark on warning components
+
 ### Security
 
 ## [0.2.1](https://github.com/nationalarchives/tna-frontend/compare/v0.2.0...v0.2.1) - 2024-07-19
diff --git a/src/nationalarchives/components/card/card.scss b/src/nationalarchives/components/card/card.scss
index ef7ce101..b722e4cb 100644
--- a/src/nationalarchives/components/card/card.scss
+++ b/src/nationalarchives/components/card/card.scss
@@ -24,6 +24,7 @@
   &--horizontal.tna-background-tint &__inner,
   &--horizontal.tna-background-accent &__inner {
     padding-right: spacing.space(1);
+    padding-bottom: spacing.space(2);
     padding-left: spacing.space(1);
   }
 
@@ -31,12 +32,6 @@
     order: 2;
   }
 
-  &__heading-link {
-    &::after {
-      display: none !important;
-    }
-  }
-
   &--full-click &__heading-link {
     &::before {
       content: "";
diff --git a/src/nationalarchives/components/warning/template.njk b/src/nationalarchives/components/warning/template.njk
index b64a4ddb..4f0b4ade 100644
--- a/src/nationalarchives/components/warning/template.njk
+++ b/src/nationalarchives/components/warning/template.njk
@@ -2,8 +2,7 @@
 {%- set classes = containerClasses | join(' ') -%}
 <div class="tna-warning{% if classes %} {{ classes }}{% endif %}"{% for attribute, value in params.attributes %} {{ attribute }}{% if value !== '' %}="{{ value }}"{% endif %}{% endfor %}>
   <h{{ params.headingLevel }} class="tna-warning__heading">
-    <span class="tna-visually-hidden">{{ params.heading or 'Important information' }}</span>
-    <span class="tna-warning__heading-icon" aria-hidden="true">!</span>
+    <span class="tna-visually-hidden">{{ params.heading or 'Important information' }}</span><span class="tna-warning__heading-icon" aria-hidden="true">!</span>
   </h{{ params.headingLevel }}>
   <div class="tna-warning__body">
     {{ params.body | safe }}
diff --git a/src/nationalarchives/utilities/typography/_index.scss b/src/nationalarchives/utilities/typography/_index.scss
index ececbab1..f5c59efc 100644
--- a/src/nationalarchives/utilities/typography/_index.scss
+++ b/src/nationalarchives/utilities/typography/_index.scss
@@ -210,7 +210,7 @@ small {
       @include colour.colour-border("link", 0.125em, solid, right);
     }
 
-    &:visited {
+    &:not(.tna-link--no-visited-state):visited {
       &::after {
         @include colour.colour-border("link-visited");
       }