Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vue3] bottom sheet props returning undefined #448

Open
dammynex opened this issue Aug 29, 2023 · 4 comments
Open

[Vue3] bottom sheet props returning undefined #448

dammynex opened this issue Aug 29, 2023 · 4 comments

Comments

@dammynex
Copy link

Bottom sheet returning all passed props as undefined for vue3

@vallemar
Copy link
Contributor

@dammynex what versión of ns-vue3 and plugin version? Can you send your package.json?

@dammynex
Copy link
Author

Here is my package.json

{
  "main": "src/app.ts",
  "version": "1.0.0",
  "private": true,
  "dependencies": {
    "@bezlepkin/nativescript-keyboard-opening": "^1.0.1",
    "@nativescript-community/ui-image": "^4.3.11",
    "@nativescript-community/ui-lottie": "^5.0.6",
    "@nativescript-community/ui-material-bottomsheet": "^7.1.4",
    "@nativescript-community/ui-pulltorefresh": "^2.5.3",
    "@nativescript-community/ui-svg": "^0.1.11",
    "@nativescript/core": "~8.5.0",
    "@nativescript/fingerprint-auth": "^8.1.0",
    "@nativescript/iqkeyboardmanager": "^2.1.1",
    "@nstudio/nativescript-carousel": "^8.0.3",
    "@triniwiz/nativescript-toasty": "^4.1.3",
    "currency-formatter": "^1.5.9",
    "generate-unique-id": "^2.0.3",
    "nativescript-contacts-chooser": "^1.1.0",
    "nativescript-vue": "3.0.0-beta.8",
    "pinia": "^2.1.6"
  },
  "devDependencies": {
    "@nativescript/android": "8.5.1",
    "@nativescript/ios": "8.5.2",
    "@nativescript/tailwind": "^2.0.1",
    "@nativescript/types": "~8.5.0",
    "@nativescript/webpack": "~5.0.0",
    "@types/node": "~17.0.21",
    "tailwindcss": "^3.1.8",
    "typescript": "~4.9.5"
  }
}

I figured I had to do defineProps(['props']) then props.props to get the props sent from the showBottomSheet function

@vallemar
Copy link
Contributor

@dammynex yes, this is a bug. In a few hours I will upload the fix

@vallemar
Copy link
Contributor

@dammynex here is the fix #449

I imagine it will take a little while to take it to master and publish a new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants