Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottom Navigation background color not applying properly #464

Open
edusperoni opened this issue May 27, 2024 · 1 comment
Open

Bottom Navigation background color not applying properly #464

edusperoni opened this issue May 27, 2024 · 1 comment

Comments

@edusperoni
Copy link
Contributor

Which platform(s) does your issue occur on?

  • iOS, latest

Please, provide the following version numbers that your issue occurs with:

  • CLI: 8.7.0
  • Cross-platform modules: 8.7.0
  • Runtime(s): 8.7.0
  • Plugin(s): version on master

Please, tell us how to recreate the issue in as much detail as possible.

Setting the background color on the TabStrip does not apply on iOS.

Is there any code involved?

on the demo file demo-snippets/vue/BottomNavigation.vue, add a green background:

                <MDTabStrip backgroundColor="green">
                    <MDTabStripItem backgroundColor="transparent">
                        <Label text="First" />
                        <Image src="font://mdi-home" class="mdi" />
                    </MDTabStripItem>

This is not applied.

This issue is apparently 2 issues:

  1. the background color on the TabStrip itself isn't set (only barTintColor). (src/bottom-navigation/index.ios.ts, adding this.viewController.tabBar.backgroundColor = value instanceof Color ? value.ios : value; seems to add the color correctly)
  2. the TabStripItem has a default background so it needs to be set to a transparent background for the previous change to apply

Unsure what's the best solution for this issue (either setting the tabBar background or using the tabBar background as the default background for the items).

@farfromrefug
Copy link
Member

@edusperoni thanks for the report should be fixed in latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants