Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the surveyor chart so that it can connect using the parameters --user --password #905

Open
MilkyWay-core opened this issue May 31, 2024 · 0 comments
Labels
proposal Enhancement idea or proposal

Comments

@MilkyWay-core
Copy link

MilkyWay-core commented May 31, 2024

What motivated this proposal?

We using helm secrets and argoCD vault plugin. We need the ability to encrypt the password in the parameters separately from the entire string
nats://login:pass@server:port doesn't work for us

What is the proposed change?

Change the chart

deployment.yaml

       args:
       {{- with .Values.config.basicCredentials }}
        - --user={{ .user }}
       {{- if .password }}
        - --password={{ .password }}
       {{- end }}
       {{- end }}

values.yaml

config:
  # Required if NATS basic auth is enabled
  # basicCredentials:
  #   user: admin
  #   password: password

Who benefits from this change?

The correct way to transfer credentials will avoid storing the password in clear text in the values.yaml

What alternatives have you evaluated?

@MilkyWay-core MilkyWay-core added the proposal Enhancement idea or proposal label May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal Enhancement idea or proposal
Projects
None yet
Development

No branches or pull requests

1 participant