Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not require "seq" field on DIRECT GET with "max_bytes" supplied #6026

Open
scottf opened this issue Oct 21, 2024 · 0 comments
Open

Do not require "seq" field on DIRECT GET with "max_bytes" supplied #6026

scottf opened this issue Oct 21, 2024 · 0 comments
Assignees
Labels
proposal Enhancement idea or proposal

Comments

@scottf
Copy link
Contributor

scottf commented Oct 21, 2024

Observed behavior

A direct message request with max_bytes but no seq (starting sequence) fails with status message "408 Empty Request" instead of returning messages.

Proposed change

Default the seq to 1

Server version

Server v2.11.0-dev

Steps to reproduce

Create a new stream and publish 5 messages with payloads of 100 bytes. Post a DIRECT.GET with {"batch":5,"max_bytes":150} and one with {"batch":5,"max_bytes":150,"seq":1}

@scottf scottf changed the title Do not require "seq" field on DIRECT GET with max_bytes supplied Do not require "seq" field on DIRECT GET with "max_bytes" supplied Oct 21, 2024
@scottf scottf added the proposal Enhancement idea or proposal label Oct 21, 2024
@derekcollison derekcollison self-assigned this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal Enhancement idea or proposal
Projects
None yet
Development

No branches or pull requests

2 participants