Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong value for two_minutes_in_nanoseconds #175

Closed
RoadRunnr opened this issue Oct 15, 2024 · 2 comments
Closed

wrong value for two_minutes_in_nanoseconds #175

RoadRunnr opened this issue Oct 15, 2024 · 2 comments

Comments

@RoadRunnr
Copy link

here:

nats.ex/lib/gnat/jetstream/api/kv.ex

Line 11 in cc237c0

@two_minutes_in_nanoseconds 1_200_000_000

There are 10^9 nanoseconds in one second, correct value is therefore 120_000_000_000 or 2 * 60 * 1_000_000_000
@mmmries
Copy link
Collaborator

mmmries commented Oct 16, 2024

Thanks for spotting that issue! I'll get it fixed in #176

@mmmries
Copy link
Collaborator

mmmries commented Oct 19, 2024

This was fixed in #176 and released in version 1.9.0 ❤️ 💛 💙 💚 💜

Thanks again for finding and reporting this issue

@mmmries mmmries closed this as completed Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mmmries @RoadRunnr