Skip to content

Commit

Permalink
fixed test - name not necessary, better for regression (#803)
Browse files Browse the repository at this point in the history
  • Loading branch information
scottf authored Nov 23, 2022
1 parent bfbf826 commit 09275d8
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions src/test/java/io/nats/client/impl/JetStreamPushTests.java
Original file line number Diff line number Diff line change
Expand Up @@ -662,13 +662,11 @@ public void testPendingLimits() throws Exception {
createDefaultTestStream(nc);

PushSubscribeOptions psoDefaultSync = PushSubscribeOptions.builder()
.name("defaultSync")
.build();

int customMessageLimit = 1000;
int customByteLimit = 1024 * 1024;
PushSubscribeOptions psoCustomSync = PushSubscribeOptions.builder()
.name("customSync")
.pendingMessageLimit(customMessageLimit)
.pendingByteLimit(customByteLimit)
.build();
Expand All @@ -688,23 +686,19 @@ public void testPendingLimits() throws Exception {
assertEquals(customByteLimit, d.getPendingByteLimit());

PushSubscribeOptions psoAsyncDefault = PushSubscribeOptions.builder()
.name("defaultAsync")
.build();

// any negative is treated as not set / ignored
PushSubscribeOptions psoAsyncLtZero = PushSubscribeOptions.builder()
.name("ltZeroAsync")
.pendingMessageLimit(-999)
.pendingByteLimit(-999)
.build();

PushSubscribeOptions psoAsyncNopeMessages = PushSubscribeOptions.builder()
.name("nopeAsyncM")
.pendingMessageLimit(customMessageLimit)
.build();

PushSubscribeOptions psoAsyncNopeBytes = PushSubscribeOptions.builder()
.name("nopeAsyncB")
.pendingByteLimit(customByteLimit)
.build();

Expand Down

0 comments on commit 09275d8

Please sign in to comment.