Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JetStream Batch Get Client support #636

Open
mtmk opened this issue Sep 23, 2024 · 2 comments · May be fixed by #680
Open

JetStream Batch Get Client support #636

mtmk opened this issue Sep 23, 2024 · 2 comments · May be fixed by #680
Assignees
Labels
help wanted Extra attention is needed new-feature

Comments

@mtmk
Copy link
Collaborator

mtmk commented Sep 23, 2024

Proposed change

ADR: https://github.com/nats-io/nats-architecture-and-design/blob/main/adr/ADR-31.md

Use case

.

Contribution

No response

@mtmk mtmk added help wanted Extra attention is needed new-feature labels Sep 23, 2024
@Ivandemidov00
Copy link
Contributor

Hi guys! I can try to solve this problem.
But I have some questions.
There is already ValueTask<NatsMsg<T>> GetDirectAsync<T>(StreamMsgGetRequest request,.... do I understand correctly that I will need to create a completely new method, for example IAsyncEnumerable<NatsMsg<T>> GetBatchDirectAsync<T>(StreamMsgBatchRequest request, ..... ?
Do I need to add support for .DIRECT.GET.{}.{} and multi_last in this request?

@mtmk
Copy link
Collaborator Author

mtmk commented Oct 28, 2024

thanks @Ivandemidov00 that would be great I think @scottf was going to work on it but not sure if he started

Edit
I talked to @scottf and he is not working on it at the moment so you can create a PR if you like.

will need to create a completely new method, for example IAsyncEnumerable<NatsMsg> GetBatchDirectAsync(StreamMsgBatchRequest request, ..... ?

Yes a new method like that looks good

Do I need to add support for .DIRECT.GET.{}.{} and multi_last in this request?

the details might change since server 2.11 still under development. which also means you'd need to develop against server main branch

Ivandemidov00 added a commit to Ivandemidov00/nats.net.v2 that referenced this issue Nov 23, 2024
Ivandemidov00 added a commit to Ivandemidov00/nats.net.v2 that referenced this issue Nov 23, 2024
* Added implementation GetBatchDirectAsync
Ivandemidov00 added a commit to Ivandemidov00/nats.net.v2 that referenced this issue Nov 23, 2024
Ivandemidov00 added a commit to Ivandemidov00/nats.net.v2 that referenced this issue Nov 23, 2024
* Modify StreamMsgBatchGetRequest
Ivandemidov00 added a commit to Ivandemidov00/nats.net.v2 that referenced this issue Nov 23, 2024
* Added tests for directGetBatch
@Ivandemidov00 Ivandemidov00 linked a pull request Nov 23, 2024 that will close this issue
Ivandemidov00 added a commit to Ivandemidov00/nats.net.v2 that referenced this issue Nov 23, 2024
* Changed tests, set SkipIfNatsServer
* Applied dotnet format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed new-feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants