Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full coverage kv management methods #535

Merged
merged 5 commits into from
Jul 6, 2024
Merged

Full coverage kv management methods #535

merged 5 commits into from
Jul 6, 2024

Conversation

Ivandemidov00
Copy link
Contributor

@Ivandemidov00 Ivandemidov00 commented Jul 2, 2024 •
edited by mtmk
Loading

@mtmk mtmk self-requested a review July 2, 2024 16:45
@Ivandemidov00
Copy link
Contributor Author

@mtmk I couldn't find the CreateOrUpdateStream api. Do I correctly understand that it is impossible to implement the CreateOrUpdateStore method without calling the server twice? Is CreateOrUpdateStore necessary under such conditions?

@mtmk mtmk linked an issue Jul 2, 2024 that may be closed by this pull request
Ensure full coverage of KV management methods #510
Closed
@mtmk
Copy link
Collaborator

mtmk commented Jul 2, 2024

@mtmk I couldn't find the CreateOrUpdateStream api. Do I correctly understand that it is impossible to implement the CreateOrUpdateStore method without calling the server twice? Is CreateOrUpdateStore necessary under such conditions?

Well spotted. let's leave that out. afaik there is no create-or-update stream call. cc @Jarema

@mtmk mtmk requested a review from rickdotnet July 3, 2024 14:49
rickdotnet
rickdotnet requested changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@rickdotnet rickdotnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from two minor suggestions, this looks great. I can make those updates if you'd like.

src/NATS.Client.KeyValueStore/NatsKVContext.cs Outdated Show resolved Hide resolved
src/NATS.Client.KeyValueStore/NatsKVContext.cs Outdated Show resolved Hide resolved
@mtmk
Copy link
Collaborator

mtmk commented Jul 6, 2024 •
edited
Loading

@Ivandemidov00 can you sign your commits next time please? (if you're comfortable with git rebase you can push -f that would be good but don't worry if not) sorry keep forgetting to remind you and you've contributed quite a bit already, we're very grateful for that 💯

edit also if you want to we'd love to have you on slack.nats.io #dotnet channel as well please feel free to drop in and say hi :o)

@rickdotnet
Copy link
Collaborator

Thanks @Ivandemidov00 ! This looks good to me.

@mtmk mtmk merged commit 432f666 into nats-io:main Jul 6, 2024
10 checks passed
mtmk added a commit that referenced this pull request Jul 6, 2024
@mtmk
Release 2.3.1-preview.1
7874a78 
* Full coverage kv management methods (#535)
* Remove unnecessary comment and configuration modification (#537)
* Unity il2cpp build fix (#543)
* Add KV Filtering of keys (#545)
* netstandard Nullable ref fix (#542)
* Fixed version number sent to server and changed lang to .NET from C#.… (#541)
@mtmk mtmk mentioned this pull request Jul 6, 2024
Merged
mtmk added a commit that referenced this pull request Jul 6, 2024
@mtmk
Release 2.3.1-preview.1 (#547)
8f5f210 
* Full coverage kv management methods (#535)
* Remove unnecessary comment and configuration modification (#537)
* Unity il2cpp build fix (#543)
* Add KV Filtering of keys (#545)
* netstandard Nullable ref fix (#542)
* Fixed version number sent to server and changed lang to .NET from C#.… (#541)
mtmk added a commit that referenced this pull request Jul 9, 2024
@mtmk
Release 2.3.1
1fe3b93 
* Fix Unity il2cpp error (#548)
* Full coverage kv management methods (#535)
* Remove unnecessary comment and configuration modification (#537)
* Add KV Filtering of keys (#545)
* netstandard Nullable ref fix (#542)
* Fixed version number sent to server and changed lang to .NET from C#.… (#541)
@mtmk mtmk mentioned this pull request Jul 9, 2024
Merged
mtmk added a commit that referenced this pull request Jul 9, 2024
@mtmk
Release 2.3.1 (#556)
92311b4 
* Fix Unity il2cpp error (#548)
* Full coverage kv management methods (#535)
* Remove unnecessary comment and configuration modification (#537)
* Add KV Filtering of keys (#545)
* netstandard Nullable ref fix (#542)
* Fixed version number sent to server and changed lang to .NET from C#.… (#541)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickdotnet rickdotnet rickdotnet approved these changes

@mtmk mtmk mtmk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure full coverage of KV management methods
3 participants
@Ivandemidov00 @mtmk @rickdotnet