Add support for auth in URL #670
Conversation
|
thanks @Mrxx99 could you please force push signed commits? it#s CNCF requirement we have the commits signed. sorry about the inconvenience :-( |
we have a few flaky tests especially on Windows but I can check if you can let me know which tests aren't passing for you |
Mrxx99
force-pushed
the
feature/auth-in-url
branch
from
17d7d1f to
ef8b414
Compare
|
@mtmk commit is signed now |
The test ist |
ah, you need nats-server.exe in your PATH |
I have, I figured this out, otherwise most tests would fail. |
|
fyi failing tests might be flappers. I'll rerun them. |
|
@Mrxx99 just added a few tests and did a minor fix in URL user-password rewrite. |
Redact passwords and tokens at the `NatsUri` level to preserve the original URIs, especially when used in WebSocket connections. This change aims to maintain backward compatibility and prevent disruptions in WebSocket connections that may rely on tokens or user-password pairs for proxy-level authentication.
Modified the NatsUri class to store the redacted URI as a string instead of a Uri object. This change simplifies the ToString method and ensures that sensitive information like user credentials is consistently redacted for logging purposes. Redacted string is created once in the ctor and avoiding Uri.ToString() calls being made everytime it's needed.
|
@Mrxx99 I moved redaction to NatsUri class to keep the original URLs since I suspect some people might be using this to go through WebSocket proxies. |
* Add support for auth in URL (#670)
* Add support for auth in URL (#670)
@mtmk As discussed, here is the PR for support for Auth in URL, I also made it to support token in URL, since if it works with username + password, I think users would also expect for it to work with a token.
Aspire PR that will uses this: dotnet/aspire#6259
Note: some Serializer unit test were already failing before I made changes.