Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of replicas check when not set on stream/consumer #1129

Closed
ripienaar opened this issue Aug 24, 2024 · 2 comments
Closed

Fix handling of replicas check when not set on stream/consumer #1129

ripienaar opened this issue Aug 24, 2024 · 2 comments
Assignees
@ploubser
Labels
defect Suspected defect such as a bug or regression

Comments

@ripienaar
Copy link
Collaborator

Observed behavior

root@nats-cli-box-5874d4d4c6-m66bq:/home# nats server check stream --stream=X
CRITICAL X Crit:Expected 0 replicas got 3 OK:0 sources | sources=0

Expected behavior

In this case the io.nats.monitor.peer-expect was not set, so probably that whole check should have been bypassed or a useful error should have been shown

Server and client version

n/a

Host environment

No response

Steps to reproduce

No response
@ripienaar ripienaar added the defect Suspected defect such as a bug or regression label Aug 24, 2024
@ripienaar
Copy link
Collaborator Author

Also worth going back a few weeks and checking how this behaved before the big recent refactors

@ripienaar
Copy link
Collaborator Author

Fixed in nats-io/jsm.go#566

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ploubser ploubser

Labels
defect Suspected defect such as a bug or regression
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ripienaar @ploubser