Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to handle multiple schemas defining different Query types #25

Open
AlecAivazis opened this issue Jan 10, 2019 · 2 comments
Open

How to handle multiple schemas defining different Query types #25

AlecAivazis opened this issue Jan 10, 2019 · 2 comments

Comments

@AlecAivazis
Copy link
Member

AlecAivazis commented Jan 10, 2019

Right now, the merging algorithm assumes that both schemas follow the convention of naming the root query type Query. This is an assumption that can lead to confusing outcomes if one of the schemas doesn't have Query defined but instead opted to have their root fields defined on something else.

With this in mind, Query shouldn't be handled like the other types in a schema. Instead, we want to merge the root types even if they dont have the same name so that they are all available at the root of the resulting API.

@jasondeutsch
Copy link

@AlecAivazis should this issue be closed or are their further requirements?

@AlecAivazis
Copy link
Member Author

AlecAivazis commented Sep 1, 2020

No, unfortunately this is still a problem. Let me add a description to the initial issue so it will be a bit more clear what I had in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants