Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Test case #17

Open
chadell opened this issue Feb 21, 2023 · 0 comments
Open

Improve Test case #17

chadell opened this issue Feb 21, 2023 · 0 comments

Comments

@chadell
Copy link
Contributor

chadell commented Feb 21, 2023

  • Seems like there's room for some common helper functions, such as checking that error != nil (or failing the test) and checking that the response is a 2xx (or failing the test).
  • Bulk operations test looks to be missing bulk-create and bulk-partial-update (PATCH) operations coverage
  • Single operations test looks to be missing partial-update (PATCH) coverage
  • Probably don't need to test CRUD for all models but it's worth thinking about testing the various bespoke endpoints (devices/napalm, jobs/run, prefixes/available-prefixes, etc.) to confirm that they appear to work correctly as generated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant