Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage in test_views.py #300

Open
glennmatthews opened this issue Feb 8, 2024 · 0 comments
Open

Improve test coverage in test_views.py #300

glennmatthews opened this issue Feb 8, 2024 · 0 comments
Assignees
Labels
status: accepted This issue has been accepted by the maintainers team for implementation

Comments

@glennmatthews
Copy link

Environment

  • Nautobot version: 2.1.3
  • nautobot-device-lifecycle-mgmt version: develop

Proposed Functionality

nautobot/nautobot#5254 caused several of the DLM list views to raise exceptions when accessed, however upstream CI test status for this App remained green / all tests passed. Looking at nautobot_device_lifecycle_mgmt/tests/test_views.py, a large number of tests are currently marked as @skip("not implemented"); my suspicion is that if these tests were implemented and enabled, they might have failed upstream CI tests due to the aforementioned issue and allowed us to catch it sooner, perhaps even before 2.1.3 was released.

Use Case

More comprehensive testing, earlier detection of fundamental breakage.

@progala progala self-assigned this Feb 22, 2024
@progala progala added the status: accepted This issue has been accepted by the maintainers team for implementation label Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepted This issue has been accepted by the maintainers team for implementation
Projects
None yet
Development

No branches or pull requests

2 participants