Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Draft] Enhancement for status field for contracts #388

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from
Draft

[Draft] Enhancement for status field for contracts #388

wants to merge 5 commits into from
+450 −17

Conversation

kvncampos
Copy link
Contributor

@kvncampos kvncampos commented Nov 15, 2024 •
edited
Loading

Closes: #337

What's Changed

  • Updated the ContractLCM Model to include a StatusField.
  • Updated forms/filters/tables related to ContractLCM.
  • Included Tests for all changes.
  • This provides the ability to keep track status of a contract through it's lifecycle

Before:
image

After:
image
image

To Do

  • [x ] Explanation of Change(s)
  • [x ] Added change log fragment(s) (for more information see the documentation)
  • [x ] Attached Screenshots, Payload Example
  • [x ] Unit, Integration Tests

qduk
qduk reviewed Jan 22, 2025
View reviewed changes
Copy link
Contributor

@qduk qduk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just going to add Status myself when I saw this PR! Hopefully we can get it approved it merged soon. I have two minor comments but other than that awesome work!

nautobot_device_lifecycle_mgmt/forms.py Outdated Show resolved Hide resolved
nautobot_device_lifecycle_mgmt/forms.py Outdated Show resolved Hide resolved
@bradh11 bradh11 changed the base branch from develop to next3.0 February 7, 2025 15:01
@bradh11 bradh11 changed the base branch from next3.0 to develop February 7, 2025 15:02
@progala progala marked this pull request as draft February 14, 2025 13:47
@progala progala changed the title enchancement for status field for contracts [Draft] Enhancement for status field for contracts Feb 14, 2025
@progala
Copy link
Contributor

progala commented Feb 14, 2025

Moving this to draft for now. This PR involves migrations that would conflict with the migrations we have in next3.0. As it is I think we should redo this PR to target v3.1.

progala
progala requested changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@progala progala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to retarget this for 3.1 due to migrations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@progala progala progala requested changes

@qduk qduk qduk approved these changes

@jvanderaa jvanderaa Awaiting requested review from jvanderaa jvanderaa is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@progala progala

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Status field to Contracts
3 participants
@kvncampos @progala @qduk