Add branch parameter to generate intended config view #871
Conversation
gsnider2195
requested review from
itdependsnetworks,
jeffkala and
nkallergis
as code owners
…m:nautobot/nautobot-app-golden-config into u/gas-828-generate-intended-config-branch
| if not filesystem_path.is_file(): | ||
| msg = f"Jinja template {filesystem_path} not found in git repository {git_repository}" | ||
| msg = f"Jinja template {rendered_path} not found in git repository {git_repository}" |
There was a problem hiding this comment.
I like this change, should be easier for the user to understand.
There was a problem hiding this comment.
Approving, I couldn't quite tell from the code but do the checkout of the branch happen in the GIT_ROOT? Or some temp location? I want to make sure there is no race condition if the intended job happens to be ran during the execution of the helper intended functionality.
The jinja templates repo is checked out to a temp location. It works off of the core feature that they're releasing in v2.4.2. |
Perfect, I assumed so. I'm good with this PR. |
Closes: #828
This cannot be released until Nautobot v2.4.2 is released with nautobot/nautobot#6746
What's Changed
This PR implements the FR in #828 to add the
branchparameter to the generate intended config UI. It also implements one of the UI enhancements requested in #862Render the graphql data tab when the graphql query select2 changes.Screen.Recording.2025-01-29.114118.mp4
To Do