Clearer logic.

oyvind-wedoe · oyvind-wedoe · commit e218c2372a77 · 2024-01-25T14:56:27.000+01:00
diff --git a/src/main/kotlin/no/nav/klage/oppgave/service/MottakService.kt b/src/main/kotlin/no/nav/klage/oppgave/service/MottakService.kt
@@ -353,11 +353,9 @@ class MottakService(
             type = type,
         )
 
-        return if (potentialDuplicate.isNotEmpty()) {
-            !potentialDuplicate.all {
-                it.utfall in listOf(Utfall.RETUR, Utfall.OPPHEVET)
-            }
-        } else false
+        return (potentialDuplicate.any {
+            it.utfall !in listOf(Utfall.RETUR, Utfall.OPPHEVET)
+        })
     }
 
     private fun validateOptionalDateTimeNotInFuture(inputDateTime: LocalDateTime?, parameterName: String) {

Original file line number	Diff line number	Diff line change
`@@ -353,11 +353,9 @@ class MottakService(`
`353`	`353`	`type = type,`
`354`	`354`	`)`
`355`	`355`
`356`		`- return if (potentialDuplicate.isNotEmpty()) {`
`357`		`- !potentialDuplicate.all {`
`358`		`- it.utfall in listOf(Utfall.RETUR, Utfall.OPPHEVET)`
`359`		`- }`
`360`		`- } else false`
	`356`	`+ return (potentialDuplicate.any {`
	`357`	`+ it.utfall !in listOf(Utfall.RETUR, Utfall.OPPHEVET)`
	`358`	`+ })`
`361`	`359`	`}`
`362`	`360`
`363`	`361`	`private fun validateOptionalDateTimeNotInFuture(inputDateTime: LocalDateTime?, parameterName: String) {`