Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IS-2649: Show content of oppfolgingsoppgave in oversikt #542

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

vetlesolgaard
Copy link
Contributor

@vetlesolgaard vetlesolgaard commented Nov 7, 2024

Hva har blitt lagt til✨🌈

  • Erstatter ikonet for oppfølgingsoppgave med et klikkbart ikon.
  • Dette klikkbare ikonet åpner en modal som viser innholdet i oppfølgingsoppgaven
  • Ikonet er bare klikkbart når veileder er i "Min oversikt"

Screenshots 📸✨

Screen.Recording.2024-11-07.at.12.16.34.mov

@vetlesolgaard vetlesolgaard force-pushed the IS-2649-Show-content-of-oppfolgingsoppgave branch from d30fbaa to 6310dd1 Compare November 7, 2024 11:13
@vetlesolgaard vetlesolgaard marked this pull request as ready for review November 7, 2024 11:17
@vetlesolgaard vetlesolgaard requested a review from a team as a code owner November 7, 2024 11:17
@vetlesolgaard vetlesolgaard force-pushed the IS-2649-Show-content-of-oppfolgingsoppgave branch from 6310dd1 to ec3b1f5 Compare November 7, 2024 11:17
@@ -107,3 +107,32 @@ export enum Oppfolgingsgrunn {
VURDER_ANNEN_YTELSE = 'VURDER_ANNEN_YTELSE',
ANNET = 'ANNET',
}

export function oppfolgingsgrunnToString(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nå vet jeg dette er bare flyttet, men er ikke dette akkurat det samme som ligger i src/data/oppfolgingsoppgave/types.ts l.53 (oppfolgingsgrunnToText)?

Copy link
Contributor Author

@vetlesolgaard vetlesolgaard Nov 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forstår ikke helt spørsmålet 😅 Det er bare flyttet ja. Så har vi fjernet en unødvendig default: case i switch casen

@vetlesolgaard vetlesolgaard force-pushed the IS-2649-Show-content-of-oppfolgingsoppgave branch from ec3b1f5 to ea1bdde Compare November 8, 2024 08:52
@vetlesolgaard vetlesolgaard force-pushed the IS-2649-Show-content-of-oppfolgingsoppgave branch from ea1bdde to 12494da Compare November 8, 2024 09:12
Copy link
Contributor

@eirikdahlen eirikdahlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ikonet er bare klikkbart når veileder er i "Min oversikt"

I videoen er man i enhetens oversikt? Men ser jo i koden at det ser riktig ut 🤷🏼‍♂️

@vetlesolgaard
Copy link
Contributor Author

Ikonet er bare klikkbart når veileder er i "Min oversikt"

I videoen er man i enhetens oversikt? Men ser jo i koden at det ser riktig ut 🤷🏼‍♂️

Ja sorry, litt misvisende 😅 Ingen lokalt som lå med en oppfølgingsoppgave. Burde stått noe om det for å spare dere forvirringen 🙈

@vetlesolgaard vetlesolgaard merged commit 5027fae into master Nov 12, 2024
3 checks passed
@vetlesolgaard vetlesolgaard deleted the IS-2649-Show-content-of-oppfolgingsoppgave branch November 12, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants