Fix outdated GraphQL query, and attempt to introduce pagination #1504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NAIS API just released v1, and as a result of that the queries in "Teamkatalogen" must be updated. v1 of NAIS API implements the Cursor Connections Specification instead of the limit / offset based pagination we previously had. Basically we fetch a page of teams, and the pageInfo object holds information about how to continue to fetch more. The query for single teams has not changed in v1, so no changes needed to be made to that. Also, the GraphQL endpoint has been changed from "/query" to "/graphql". More info: - https://github.com/nais/api/blob/main/docs/graphql_practices.md#pagination - https://relay.dev/graphql/connections.htm
erik-a-e
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NAIS API just released v1, and as a result of that the queries in "Teamkatalogen" must be updated.
v1 of NAIS API implements the Cursor Connections Specification instead of the limit / offset based pagination we previously had.
Basically we fetch a page of teams, and the
pageInfoobject holds information about how to continue to fetch more.The query for a single team has not changed in v1, so there was no need to update that.
Also, the GraphQL endpoint has been changed from "/query" to "/graphql".
Take into consideration that Java is not a language that I use on a daily basis (this is probably the first time I have written Java in over 20 years), so feel free to make any change you deem necessary.
More info: