From 1ba3b9b00bb9e97c4ccbbcd8939d056e7840dbcd Mon Sep 17 00:00:00 2001 From: kristenhaerum Date: Mon, 5 Aug 2024 13:53:08 +0200 Subject: [PATCH] Rename Arbeidsgiver class to ArbeidsgiverSkatt #deploy-skattekort-service #deploy-test-dolly-backend Renamed the Arbeidsgiver class to ArbeidsgiverSkatt for clarity and improved domain specificity. Updated all occurrences and references in DTOs to reflect the change. This ensures consistency across the codebase and improves readability. --- .../domain/resultset/skattekort/SkattekortRequestDTO.java | 6 +++--- .../v1/{Arbeidsgiver.java => ArbeidsgiverSkatt.java} | 2 +- .../libs/dto/skattekortservice/v1/SkattekortRequestDTO.java | 4 ++-- .../dto/skattekortservice/v1/SkattekortResponseDTO.java | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) rename libs/data-transfer-objects/src/main/java/no/nav/testnav/libs/dto/skattekortservice/v1/{Arbeidsgiver.java => ArbeidsgiverSkatt.java} (94%) diff --git a/apps/dolly-backend/src/main/java/no/nav/dolly/domain/resultset/skattekort/SkattekortRequestDTO.java b/apps/dolly-backend/src/main/java/no/nav/dolly/domain/resultset/skattekort/SkattekortRequestDTO.java index fb7c90eca20..8f6485aa6c7 100644 --- a/apps/dolly-backend/src/main/java/no/nav/dolly/domain/resultset/skattekort/SkattekortRequestDTO.java +++ b/apps/dolly-backend/src/main/java/no/nav/dolly/domain/resultset/skattekort/SkattekortRequestDTO.java @@ -4,7 +4,7 @@ import lombok.Builder; import lombok.Data; import lombok.NoArgsConstructor; -import no.nav.testnav.libs.dto.skattekortservice.v1.Arbeidsgiver; +import no.nav.testnav.libs.dto.skattekortservice.v1.ArbeidsgiverSkatt; import java.util.ArrayList; import java.util.List; @@ -17,9 +17,9 @@ @AllArgsConstructor public class SkattekortRequestDTO { - private List arbeidsgiverSkatt; + private List arbeidsgiverSkatt; - public List getArbeidsgiverSkatt() { + public List getArbeidsgiverSkatt() { if (isNull(arbeidsgiverSkatt)) { diff --git a/libs/data-transfer-objects/src/main/java/no/nav/testnav/libs/dto/skattekortservice/v1/Arbeidsgiver.java b/libs/data-transfer-objects/src/main/java/no/nav/testnav/libs/dto/skattekortservice/v1/ArbeidsgiverSkatt.java similarity index 94% rename from libs/data-transfer-objects/src/main/java/no/nav/testnav/libs/dto/skattekortservice/v1/Arbeidsgiver.java rename to libs/data-transfer-objects/src/main/java/no/nav/testnav/libs/dto/skattekortservice/v1/ArbeidsgiverSkatt.java index 24de5895b0f..2aa7c31153c 100644 --- a/libs/data-transfer-objects/src/main/java/no/nav/testnav/libs/dto/skattekortservice/v1/Arbeidsgiver.java +++ b/libs/data-transfer-objects/src/main/java/no/nav/testnav/libs/dto/skattekortservice/v1/ArbeidsgiverSkatt.java @@ -14,7 +14,7 @@ @Builder @NoArgsConstructor @AllArgsConstructor -public class Arbeidsgiver { +public class ArbeidsgiverSkatt { private IdentifikatorForEnhetEllerPerson arbeidsgiveridentifikator; private List arbeidstaker; diff --git a/libs/data-transfer-objects/src/main/java/no/nav/testnav/libs/dto/skattekortservice/v1/SkattekortRequestDTO.java b/libs/data-transfer-objects/src/main/java/no/nav/testnav/libs/dto/skattekortservice/v1/SkattekortRequestDTO.java index 0aa629dd051..c11c69b16e3 100644 --- a/libs/data-transfer-objects/src/main/java/no/nav/testnav/libs/dto/skattekortservice/v1/SkattekortRequestDTO.java +++ b/libs/data-transfer-objects/src/main/java/no/nav/testnav/libs/dto/skattekortservice/v1/SkattekortRequestDTO.java @@ -16,9 +16,9 @@ @AllArgsConstructor public class SkattekortRequestDTO { - private List arbeidsgiver; + private List arbeidsgiver; - public List getArbeidsgiver() { + public List getArbeidsgiver() { if (isNull(arbeidsgiver)) { arbeidsgiver = new ArrayList<>(); diff --git a/libs/data-transfer-objects/src/main/java/no/nav/testnav/libs/dto/skattekortservice/v1/SkattekortResponseDTO.java b/libs/data-transfer-objects/src/main/java/no/nav/testnav/libs/dto/skattekortservice/v1/SkattekortResponseDTO.java index e0a95fe06c9..53228268f21 100644 --- a/libs/data-transfer-objects/src/main/java/no/nav/testnav/libs/dto/skattekortservice/v1/SkattekortResponseDTO.java +++ b/libs/data-transfer-objects/src/main/java/no/nav/testnav/libs/dto/skattekortservice/v1/SkattekortResponseDTO.java @@ -18,10 +18,10 @@ public class SkattekortResponseDTO { private String ident; private String inntektsaar; - private List arbeidsgiver; + private List arbeidsgiver; private String skattekortXml; - public List getArbeidsgiver() { + public List getArbeidsgiver() { if (isNull(arbeidsgiver)) { arbeidsgiver = new ArrayList<>();