Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rydde opplysningstype foedsel #3603

Merged
merged 6 commits into from
Sep 2, 2024
Merged

Conversation

krharum
Copy link
Contributor

@krharum krharum commented Sep 2, 2024

#deploy-person-search-service

Renamed FoedselDTO and related classes to FoedselsdatoDTO for better clarity. Updated corresponding references in various parts of the codebase to reflect this change.

#deploy-person-search-service

Renamed `FoedselDTO` and related classes to `FoedselsdatoDTO` for better clarity. Updated corresponding references in various parts of the codebase to reflect this change.
Implemented getter methods for 'bostedsadresse' and 'folkeregisterpersonstatus' fields. These methods initialize the fields to an empty list if they are null, ensuring that the application handles empty lists gracefully.
Updated the property name 'foedsel' to 'foedselsdato' for consistency across the utils.tsx and Alder.tsx files. This change ensures uniform naming conventions are maintained and enhances code readability. Adjusted related paths and labels accordingly.
Renamed the 'foedsel' field to 'foedselsdato' across multiple files and classes. This change updates both the JSON structure and Java classes to reflect the new field name for consistency and clarity. Removed deprecated birth-related fields and adjusted corresponding tests.
Revised the GraphQL query to prioritize foedselsdato, removing redundant fields. Additionally, introduced a new pdl-api-schema.graphql file to define the complete API schema for consistency and future extensions.
@krharum krharum marked this pull request as ready for review September 2, 2024 10:09
@krharum krharum requested a review from a team as a code owner September 2, 2024 10:09
Copy link
Contributor

@stigus stigus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ser flott ut 😄

@krharum krharum merged commit a4ce921 into master Sep 2, 2024
9 checks passed
@krharum krharum deleted the bugfix/rydde-foedsel-artifact branch September 2, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants