Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change/clientcredential_factory #3695

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

rfc3092
Copy link
Contributor

@rfc3092 rfc3092 commented Dec 12, 2024

Fullfører ny TODO i #3693.

Samler extends ClientCredential i security-core, og skriver om til factory og beans, med meta-dok. Ønsker å unngå @Import. Fail fast med litt mer hjelpsom feilmelding, og defaults for test profile.

Fjerner samtidig et par ubrukte klasser i reactive-security.

- Added factory for autoconfiguration of ClientCredential beans.
- Added default beans for "test" profile.
@rfc3092 rfc3092 mentioned this pull request Dec 12, 2024
@rfc3092 rfc3092 marked this pull request as ready for review December 13, 2024 09:41
@rfc3092 rfc3092 requested a review from a team as a code owner December 13, 2024 09:41
Copy link
Contributor

@stigus stigus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ser flott ut 😎

# Conflicts:
#	libs/reactive-security/src/main/java/no/nav/testnav/libs/reactivesecurity/domain/AzureNavProxyClientCredential.java
#	libs/reactive-security/src/main/java/no/nav/testnav/libs/reactivesecurity/domain/AzureTrygdeetatenClientCredential.java
#	libs/security-core/src/main/java/no/nav/testnav/libs/securitycore/domain/azuread/AzureNavClientCredential.java
#	libs/security-core/src/main/java/no/nav/testnav/libs/securitycore/domain/azuread/ClientCredential.java
#	libs/security-core/src/main/resources/META-INF/additional-spring-configuration-metadata.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants