Pek 715 hente simulert tjenestepensjon spk #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
antonfofanov
commented
Nov 26, 2024
antonfofanov
commented
- Afp skal hentes fra SPK og logges uten å bli tatt videre.
- Hvis brukeren har valgt om å simulere uten AFP, skal brukeren få BTP og brukeren skal få vite at BTP er med i det totale beløpet
…ntekt. Flere tester
…t-tjenestepensjon-spk
espengjostol
approved these changes
Nov 26, 2024
| @@ -0,0 +1,3 @@ | |||
| package no.nav.tjenestepensjon.simulering.v2025.tjenestepensjon.v1.exception | |||
|
|
|||
| class TpregisteretException(s: String) : RuntimeException(s) | |||
There was a problem hiding this comment.
Bør bruke mer beskrivende navn enn "s". Forslag: "message"
| ordningsListe = response.inkludertOrdningListe.map { Ordning(it.tpnr) }, | ||
| utbetalingsperioder = response.utbetalingsListe.map { Utbetalingsperiode(it.fraOgMedDato, it.manedligUtbetaling, it.ytelseType) }, | ||
| aarsakIngenUtbetaling = response.arsakIngenUtbetaling | ||
| aarsakIngenUtbetaling = response.arsakIngenUtbetaling, | ||
| betingetTjenestepensjonErInkludert = response.utbetalingsListe.any { it.ytelseType == "BTP" } |
There was a problem hiding this comment.
Ytelsestyper burde være definert i en enum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.