-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only 1 available server (when consistency settings requires 2) generates misleading exception #250
Comments
knocte
added a commit
that referenced
this issue
Jan 24, 2024
This is the first part of a bugfix for issue 250 [1]. The exception was misleading because it was not really an inconsistecy but rather lacking availability. [1] #250
knocte
added a commit
that referenced
this issue
Jan 24, 2024
This is the first part of a bugfix for issue 250 [1]. The exception was misleading because it was not really an inconsistecy but rather lacking availability. [1] #250
knocte
added a commit
that referenced
this issue
Jan 24, 2024
This is the first part of a bugfix for issue 250 [1]. The exception was misleading because it was not really an inconsistecy but rather lacking availability. [1] #250
knocte
added a commit
that referenced
this issue
Jan 24, 2024
This is the first part of a bugfix for issue 250 [1]. The exception was misleading because it was not really an inconsistecy but rather lacking availability. [1] #250
knocte
added a commit
that referenced
this issue
Jan 24, 2024
This is the first part of a bugfix for issue 250 [1]. The exception was misleading because it was not really an inconsistecy but rather lacking availability. [1] #250
knocte
added a commit
that referenced
this issue
Jan 24, 2024
This InconsistentResultFromDifferentServersOfSameCurrency exception type was introduced in [1], but after implementing an improvement[2] over the exception message and type of another problem, I realised that the new exception thrown in [2] wouldn't be covered by the exception type mentioned above, so we need it to be more generic (to receive any exception as innerException), so let's do that and rename it. This commit in conjunction with [2] don't really fix issue 250 [3], but it might mitigate it, and anyway thanks to [1] if it happens again, we will receive a different exception, with different exception message as well, so let's close [3]. Closes #250 [1] 8fa47e0 [2] 5eca671 [3] #250
knocte
added a commit
that referenced
this issue
Jan 24, 2024
This InconsistentResultFromDifferentServersOfSameCurrency exception type was introduced in [1], but after implementing an improvement[2] over the exception message and type of another problem, I realised that the new exception thrown in [2] wouldn't be covered by the exception type mentioned above, so we need it to be more generic (to receive any exception as innerException), so let's do that and rename it. This commit in conjunction with [2] don't really fix issue 250 [3], but it might mitigate it, and anyway thanks to [1] if it happens again, we will receive a different exception, with different exception message as well, so let's close [3]. Closes #250 [1] 8fa47e0 [2] 5eca671 [3] #250
knocte
added a commit
that referenced
this issue
Jan 24, 2024
This InconsistentResultFromDifferentServersOfSameCurrency exception type was introduced in [1], but after implementing an improvement[2] over the exception message and type of another problem, I realised that the new exception thrown in [2] wouldn't be covered by the exception type mentioned above, so we need it to be more generic (to receive any exception as innerException), so let's do that and rename it. This commit in conjunction with [2] don't really fix issue 250 [3], but it might mitigate it, and anyway thanks to [1] if it happens again, we will receive a different exception, with different exception message as well, so let's close [3]. Closes #250 [1] 8fa47e0 [2] 5eca671 [3] #250
knocte
added a commit
that referenced
this issue
Jan 25, 2024
Backend: improve inconsistency edge case. Closes #250
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps to reproduce:
Current results:
Expected results:
This exception should not be raised, and FTPC should keep trying with different servers to find 1 more consistent result.
The text was updated successfully, but these errors were encountered: