Merge pull request 3liz#5105 from Gustry/action-error

Display a generic error in case of action failure to the end-user
nboisteault · Dec 11, 2024 · b4bec8d · b4bec8d
2 parents 4a9aa14 + 761051a
commit b4bec8d
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/lizmap/modules/action/controllers/service.classic.php b/lizmap/modules/action/controllers/service.classic.php
@@ -54,7 +54,7 @@ public function index()
         // Redirect if the user has no right to access this repository
         if (!$lizmapProject->checkAcl()) {
             $errors = array(
-                'title' => 'Access forbiden',
+                'title' => 'Access forbidden',
                 'detail' => jLocale::get('view~default.repository.access.denied'),
             );
 
@@ -201,10 +201,14 @@ public function index()
                 $data = json_decode($r->data);
             }
         } catch (Exception $e) {
-            jLog::log('Error in project '.$repository.'/'.$project.', layer '.$layerId.', while running the query : '.$sql, 'lizmapadmin');
+            jLog::log(
+                'Error in project '.$repository.'/'.$project.', layer '.$layerId.', '.
+                'while running the action with the PostgreSQL query : '.$sql.' → '.$e->getMessage(),
+                'lizmapadmin'
+            );
             $errors = array(
-                'title' => 'An error occurred while running the PostgreSQL query !',
-                'detail' => $e->getMessage(),
+                'title' => 'An error occurred while processing the request',
+                'detail' => 'Please contact the GIS administrator to look to the administrator logs.',
             );
 
             return $this->error($errors);