Recognize pre-release tables #156
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aboshkin
reviewed
Oct 4, 2024
|
The problem with the ones from the SRAO ticket is that KDB does not recognize them as pre-release tables. I thought they'd work for a test case but I was wrong. That's why I don't have a test case. :( You can pass it or fail it. It is not testable (and neither is KDBPathType in this case). Maybe it's time to deprecate the concept of a pre-release KDB table. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code is not wrong. As far as KDB is concerned, it is correct. It is the same logic that KDBPathType uses, and KDBPathContents should match KDBPathType. But as far as I can tell, we have no files that are so old that KDBPathType would recognize them as pre-release tables.