Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_search_obo_id unit test failures #146

Closed
alexskr opened this issue May 3, 2024 · 3 comments
Closed

test_search_obo_id unit test failures #146

alexskr opened this issue May 3, 2024 · 3 comments
Assignees

Comments

@alexskr
Copy link
Member

alexskr commented May 3, 2024

unit test fails with latest goo and ontologies_linked_data:

  2) Failure:
TestSearchController#test_search_obo_id [/srv/ontoportal/ontologies_api/test/controllers/test_search_controller.rb:270]:
Failed assertion, no message given.

I think this line
assert acr_1 === ncit_acronym || acr_1 === ogms_acronym can be rewritten as assert_includes [ncit_acronym, ogms_acronym], acr_1 to get a better feedback from unit test

if we do that we see more useful error:

  1) Failure:
TestSearchController#test_search_obo_id [/srv/ontoportal/ontologies_api/test/controllers/test_search_controller.rb:270]:
Expected ["NCIT", "OGMS"] to include "CNO".
alexskr added a commit that referenced this issue May 3, 2024
changes allows to see more detailed output when unit test fail
as in #146
@alexskr
Copy link
Member Author

alexskr commented May 3, 2024

ontologies_linked_data PR#143 seems to be the culprit

@alexskr
Copy link
Member Author

alexskr commented May 4, 2024

unit tests are failing because some of the changes in ncbo/ontologies_linked_data#153 PR were rolled back by ncbo/ontologies_linked_data#143

@alexskr
Copy link
Member Author

alexskr commented May 6, 2024

addressed in ncbo/ontologies_linked_data@a3f6cf0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants