Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: enforce user creation security #131

Merged
merged 6 commits into from
Nov 30, 2023
Merged

Feature: enforce user creation security #131

merged 6 commits into from
Nov 30, 2023

Conversation

syphax-bouazzouni
Copy link

@syphax-bouazzouni syphax-bouazzouni commented Nov 28, 2023 •
edited
Loading

This PR enforces the user creation/deletion security.

Now only an admin user can create an admin user or update a user to an admin, and only admin users can delete another user.

More detail can be found in the added tests.

@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2c3cba8) 71.85% compared to head (6e68eaf) 71.88%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #131      +/-   ##
===========================================
+ Coverage    71.85%   71.88%   +0.02%     
===========================================
  Files           52       52              
  Lines         2878     2881       +3     
===========================================
+ Hits          2068     2071       +3     
  Misses         810      810
Flag Coverage Δ
unittests 71.88% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syphax-bouazzouni syphax-bouazzouni force-pushed the feature/fix-user-creation-security branch from 09de2b0 to f34a96f Compare November 28, 2023 04:28
This was referenced Nov 28, 2023
Merged
Merged
@alexskr
Copy link
Member

alexskr commented Nov 28, 2023

@syphax-bouazzouni, when making pull requests against develop branch, ideally we should keep gem branch specifier set at develop in the Gemfile
in this case, is there a way to remove [0402dc4] (0402dc4) commit?

@syphax-bouazzouni syphax-bouazzouni force-pushed the feature/fix-user-creation-security branch from f34a96f to 5ace41c Compare November 28, 2023 05:01
@syphax-bouazzouni
Copy link
Author

@syphax-bouazzouni, when making pull requests against develop branch, ideally we should keep gem branch specifier set at develop in the Gemfile in this case, is there a way to remove [0402dc4] (0402dc4) commit?

Done,
Sorry for that, it was because I started my branch from master not develop.

@alexskr alexskr merged commit 1a62241 into ncbo:develop Nov 30, 2023
2 checks passed
@syphax-bouazzouni syphax-bouazzouni mentioned this pull request Dec 19, 2023
Closed
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@syphax-bouazzouni @codecov-commenter @alexskr