Feature: Add the slices CRUD endpoints #87

syphax-bouazzouni · 2022-05-23T16:33:50Z

Forked from #19

This PR adds the following endpoints :

Create slice POST https://data.bioontology.org/sclices
Get slice details GET https://data.bioontology.org/sclices/:slice_id
Update slide info POST https://data.bioontology.org/sclices/:slice_id
Delete a slice DELETE https://data.bioontology.org/sclices/:slice_id

Our long-term vision behind slices can be found here; In brief gives the possibility the users to create their slices, with their ontologies, colors, and logo, .... Making Ontoportal a sort a Portal provider for people that don't want or don't have the resources to deploy there own instances (and with portal federation, everything will be also connected).

The biggest blocker here, about the slice features is that we can't can't dynamically create a DSN configuration for each of the slices created by a user.

alexskr · 2023-09-07T21:25:52Z

should slice creation/update be restricted to users with administrative privileges?

alexskr · 2023-09-07T21:29:37Z

The biggest blocker here, about the slice features is that we can't can't dynamically create a DSN configuration for each of the slices created by a user.

it can be done with wildcard subdomains.

syphax-bouazzouni · 2023-09-07T21:33:45Z

Should slice creation/update be restricted to users with administrative privileges?
Now that I have checked again my own code (a year) later, it is true that with this version anyone can create and delete a slice there is no ownership in the current model.

For now, I added a security check on each of the slice write operations. That prevents no admin users from editing them.

 error 403, "Access denied" unless current_user && current_user.admin?

…endpoint

alexskr · 2023-09-15T17:26:56Z

@syphax-bouazzouni, thanks for adding security check.
Would you please add necessary unit tests for the new functionality.

alexskr · 2023-09-15T17:33:07Z

it would also be a good idea to restrict the use of underscores (_) in the slice names.
Underscores are generally allowed in subdomain names according to the DNS specification. However, it's important to note that while they are technically allowed, they may not be supported or accepted by all DNS servers, web browsers, software applications and certificate authorities.

syphax-bouazzouni · 2023-10-28T09:07:09Z

@syphax-bouazzouni, thanks for adding security check. Would you please add necessary unit tests for the new functionality.

Added here 6dc238d

it would also be a good idea to restrict the use of underscores (_) in the slice names. Underscores are generally allowed in subdomain names according to the DNS specification. However, it's important to note that while they are technically allowed, they may not be supported or accepted by all DNS servers, web browsers, software applications and certificate authorities.

Added ncbo/ontologies_linked_data#176

codecov-commenter · 2023-10-28T09:25:38Z

Codecov Report

Merging #87 (8489f2b) into master (9743042) will increase coverage by 0.01%.
Report is 49 commits behind head on master.
The diff coverage is 69.76%.

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
+ Coverage   71.84%   71.85%   +0.01%     
==========================================
  Files          52       52              
  Lines        2845     2878      +33     
==========================================
+ Hits         2044     2068      +24     
- Misses        801      810       +9

Flag	Coverage Δ
unittests	`71.85% <69.76%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
controllers/metrics_controller.rb	`58.69% <100.00%> (-1.73%)`	⬇️
controllers/ontology_analytics_controller.rb	`100.00% <100.00%> (ø)`
controllers/ontology_submissions_controller.rb	`73.07% <100.00%> (+3.17%)`	⬆️
helpers/access_control_helper.rb	`83.33% <ø> (-1.29%)`	⬇️
helpers/application_helper.rb	`90.33% <100.00%> (+0.42%)`	⬆️
controllers/slices_controller.rb	`66.66% <59.37%> (-33.34%)`	⬇️

…pr/add-slice-get-endpoint

alexskr · 2023-10-30T17:01:52Z

@syphax-bouazzouni, Looks great!

mdorf · 2023-11-01T20:39:13Z

@syphax-bouazzouni, we want to merge this PR, but it contains a dependency on a specific branch of 'ontoportal-lirmm/ontologies_linked_data':

gem 'ontologies_linked_data', github: 'ontoportal-lirmm/ontologies_linked_data', branch: 'pr/feature/extend-slice-acronym-validator'

We definitely don't want to add this dependency to our codebase. This PR doesn't make it clear what functionality/code exactly it requires from that 'ontoportal-lirmm/ontologies_linked_data' branch. Is there another PR that contains that functionality?

mdorf · 2023-11-01T21:39:37Z

If we merge the PR ncbo/ontologies_linked_data#176, can we then remove the dependency on ontoportal-lirmm, or are there other changes that need to be merged first?

syphax-bouazzouni · 2023-11-01T21:56:25Z

If we merge the PR ncbo/ontologies_linked_data#176, can we then remove the dependency on ontoportal-lirmm, or are there other changes that need to be merged first?

Yes, this change in the Gemfile, was just to pass the tests.

…-acronym-validator Merging in order to fulfill a dependency required by ncbo/ontologies_api#87

…onward (#4) * fix get a submission metrics * Auto stash before merge of "upstream" and "upstream/master" * add the slice get endpoint * add the slices create endpoint * add the slices delete endpoint * add the slices update endpoint * Add caching for analytics for 24 hours. * Fix for #97. Check for ontology existence before brining attributes * Handle edge case for submission downloads which do not have UploadFilePath set Fixes #98 * Gemfile.lock update * Add GH workflow for capistrano deployments * Update Gemfile.lock * fix ability to run deployment manually * Fix for deprecation notice of Rack::Attack.throttled_response Update configuration to closely match rack attack documentation in order to address deprecation notice: [DEPRECATION] Rack::Attack.throttled_response is deprecated. Please use Rack::Attack.throttled_responder instead * Update version of actions/checkout to address deprecation notices * Fix: Documentation rendering (#107) * Auto stash before merge of "upstream" and "upstream/master" * fix haml gem version * Update Gemfile * Restore branch specifier to master * Update capistrano sample config to include setting which branch to deploy from * Gemfile.lock update * Gemfile.lock update * Gemfile.lock update * Gemfile.lock update * Make sure ontology is present when accessing submissions. Fixes an internal server error when accessing submission for non-existent/deleted ontology * Remove owlapi_wrapper.jar file. It is included elsewhere * Add health checks for docker services and add more config file options * Remove wait-for-it * Add health check to AG service * Add GH workflow for publishing docker images * Add missing redis port number * Restore branch specifier to develop * Set mgrep port to 55556 * add arm64 platform * bump up version of solr-ut * Fix ncbo#116 - pinned redis-store to 1.9.1 until #358 gets resolved - fixed deprecation notices "warning: calling URI.open via Kernel#open is deprecated, call URI.open directly or use URI#open" * Restore branch specifier to master * fix for wrongly replaced string * Delete fix_purls.rb fix_purls.rb moved to a rake task under ncbo_cron project * Remove google analytics depenencies since those needed only in ncbo_cron * bump up major version of oj and faraday * remove search_index.rb script * lock gem rack-cache to 1.13.0 see ncbo#118 * remove depenency on redis-activesupport rack-attack can work with redis directly so there is no need to use redis-activesupport which is no longer being actively developed * unpin redis-store solves: ncbo#105 ncbo#106 * use redis-store from forked repo containing redis 5 compat fixes this should be reverted back to original after redis 5 copatibilty issues are resolved * use patched version of agraph v7.3.1 * unpin faraday gem * Gemfile.lock update * fixed an issue with the GA4 Analytics migration * fixed an issue with the GA4 Analytics migration * reduce request limit for resource intensive api calls (#121) * Announce deployments in NewRelic (#124) * Record deployments to NewRelic https://docs.newrelic.com/docs/apm/agents/ruby-agent/features/record-deployments-ruby-agent/ * add newrelic to deployment group github actions deployment doesn't install default group so capistrano fails to find newrelic recepies unless we add it to the deployment group * add rubocop * Gemfile update, goo version including goo#138 and goo#139 * Gemfile.lock update * Gemfile.lock update * Gemfile.lock update * update slice write operation to check if user is admin * Gemfile.lock update * fixed an accidental commit of docker compose file * fixed Gemfile after merging from master * Gemfile.lock update * update Gemfile.lock * Gemfile.lock update * redis-store gem with redis 5 compatibility fix * Gemfile.lock update * make the check_access helper use filter_access if the object is a list * add test for submissions access check with two ontologies private and pubic * check access of ontologies in /ontologies/:acronym/submissions endpoint * Set gem branch specifier to develop * reset branch specifier to master * add the slice get endpoint * add the slices create endpoint * add the slices delete endpoint * add the slices update endpoint * update slice write operation to check if user is admin * add slices creation & deletion unit tests * Gemfile.lock update * Gemfile.lock update * Merged #87 from master * fixed Gemfile after merge * Gemfile.lock update * update Gemfile.lock * Add configurable option for github org where code is deployed from * Gemfile update * Gemfile update * check existance of acroym before fetching details fixes #129 * extract slice tests helper to the parent class for reusability * add a test for the creation of an admin user * enforce the security of admin user creation * enforce user deletion security to be admin only * Gemfile.lock update * update Gemfile.lock * Gemfile update * implemented the first pass at bmir-radx/radx-project#37 * set bundler version to be comptatible with ruby 2.7 * Gemfile.lock update * implemented #127 - Add API call to trigger ontology pull from remote location * Gemfile.lock * implemented a test for #127 - Add API call to trigger ontology pull from remote location * Gemfile.lock update * implemented a test for #127 - Add API call to trigger ontology pull from remote location * implemented a test for #127 - Add API call to trigger ontology pull from remote location * Gemfile.lock update * use agraph v8.0.0 * Gemfile.lock update * Gemfile.lock update --------- Co-authored-by: Alex Skrenchuk <[email protected]> Co-authored-by: mdorf <[email protected]> Co-authored-by: Jennifer Vendetti <[email protected]>

syphax-bouazzouni added 4 commits May 23, 2022 18:24

add the slice get endpoint

84d100f

add the slices create endpoint

d822e95

add the slices delete endpoint

6b598b5

add the slices update endpoint

a1d37f0

This was referenced May 23, 2022

we need to think if we do a pull request of the /synchronize_groups with slices agroportal/project-management#272

Closed

The slice API endpoint does not work for specific slice ontoportal-lirmm/ontologies_api#13

Closed

alexskr mentioned this pull request Sep 7, 2023

add a post method to create a new slice #19

Closed

alexskr requested a review from mdorf September 7, 2023 21:18

update slice write operation to check if user is admin

b4bac7e

syphax-bouazzouni changed the title ~~Add the slices CRUD endpoints~~ Feature: Add the slices CRUD endpoints Sep 7, 2023

Merge remote-tracking branch 'upstream/master' into pr/add-slice-get-…

719d500

…endpoint

alexskr mentioned this pull request Sep 15, 2023

rename obo_foundry slice to obo-foundry ncbo/bioportal-project#278

Closed

This was referenced Oct 27, 2023

create a RADx slice in BioPortal bmir-radx/radx-project#30

Closed

create OBO Library slice ncbo/bioportal-project#284

Closed

syphax-bouazzouni mentioned this pull request Oct 28, 2023

Feature: extend slice acronym validator to not accept underscore ncbo/ontologies_linked_data#176

Merged

syphax-bouazzouni added 6 commits October 28, 2023 10:21

add the slice get endpoint

6f89433

add the slices create endpoint

e7b6cb3

add the slices delete endpoint

aad2173

add the slices update endpoint

37f539b

update slice write operation to check if user is admin

c987f55

add slices creation & deletion unit tests

6dc238d

Merge remote-tracking branch 'origin/pr/add-slice-get-endpoint' into …

8489f2b

…pr/add-slice-get-endpoint

syphax-bouazzouni force-pushed the pr/add-slice-get-endpoint branch from 57a527f to 8489f2b Compare October 28, 2023 15:07

mdorf added a commit to ncbo/ontologies_linked_data that referenced this pull request Nov 1, 2023

Merge pull request #176 from ontoportal-lirmm/pr/feature/extend-slice…

d5bbed1

…-acronym-validator Merging in order to fulfill a dependency required by ncbo/ontologies_api#87

mdorf merged commit 803b3b6 into ncbo:master Nov 1, 2023
2 checks passed

mdorf added a commit that referenced this pull request Nov 2, 2023

Merged #87 from master

fb9bcf4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature: Add the slices CRUD endpoints #87

Feature: Add the slices CRUD endpoints #87

syphax-bouazzouni commented May 23, 2022 •

edited

Loading

alexskr commented Sep 7, 2023

alexskr commented Sep 7, 2023 •

edited

Loading

syphax-bouazzouni commented Sep 7, 2023 •

edited

Loading

alexskr commented Sep 15, 2023

alexskr commented Sep 15, 2023 •

edited

Loading

syphax-bouazzouni commented Oct 28, 2023

codecov-commenter commented Oct 28, 2023 •

edited

Loading

alexskr commented Oct 30, 2023

mdorf commented Nov 1, 2023 •

edited

Loading

mdorf commented Nov 1, 2023

syphax-bouazzouni commented Nov 1, 2023

Feature: Add the slices CRUD endpoints #87

Feature: Add the slices CRUD endpoints #87

Conversation

syphax-bouazzouni commented May 23, 2022 • edited Loading

alexskr commented Sep 7, 2023

alexskr commented Sep 7, 2023 • edited Loading

syphax-bouazzouni commented Sep 7, 2023 • edited Loading

alexskr commented Sep 15, 2023

alexskr commented Sep 15, 2023 • edited Loading

syphax-bouazzouni commented Oct 28, 2023

codecov-commenter commented Oct 28, 2023 • edited Loading

Codecov Report

alexskr commented Oct 30, 2023

mdorf commented Nov 1, 2023 • edited Loading

mdorf commented Nov 1, 2023

syphax-bouazzouni commented Nov 1, 2023

syphax-bouazzouni commented May 23, 2022 •

edited

Loading

alexskr commented Sep 7, 2023 •

edited

Loading

syphax-bouazzouni commented Sep 7, 2023 •

edited

Loading

alexskr commented Sep 15, 2023 •

edited

Loading

codecov-commenter commented Oct 28, 2023 •

edited

Loading

mdorf commented Nov 1, 2023 •

edited

Loading