Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing unit test for IRI extraction #200

Closed
alexskr opened this issue May 6, 2024 · 2 comments
Closed

Missing unit test for IRI extraction #200

alexskr opened this issue May 6, 2024 · 2 comments

Comments

@alexskr
Copy link
Member

alexskr commented May 6, 2024

We are missing the unit test for IRI extraction introduced in
#153

It is indirectly tested by OBO ID search, which relies on IRI; however, a direct unit test would provide more clarity.
@syphax-bouazzouni
Copy link

this PR #199 includes a unit test for the extraction step called test_extraction_metadata(https://github.com/ncbo/ontologies_linked_data/pull/199/files#diff-a121859f7a845ade0d5d33bb88b4fea2511f9c9d31b99aad291006f5ce20398dR1152)

@alexskr
Copy link
Member Author

alexskr commented May 6, 2024

great! thanks!

@syphax-bouazzouni syphax-bouazzouni mentioned this issue May 18, 2024
Merged
@alexskr alexskr closed this as completed Jun 11, 2024
@alexskr alexskr mentioned this issue Jun 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexskr @syphax-bouazzouni