Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Split mappings_ontologies method to small functions #159

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

syphax-bouazzouni
Copy link

@syphax-bouazzouni syphax-bouazzouni commented Sep 23, 2022

Includes

Changes

@syphax-bouazzouni syphax-bouazzouni force-pushed the pr/refactor/simple-refactor-mapping-ontologies branch from 5c1f5d7 to 117c31b Compare September 23, 2022 13:20
@codecov
Copy link

codecov bot commented Dec 17, 2022

Codecov Report

Merging #159 (44d8506) into master (4f9139d) will increase coverage by 0.12%.
The diff coverage is 96.11%.

@@            Coverage Diff             @@
##           master     #159      +/-   ##
==========================================
+ Coverage   80.72%   80.84%   +0.12%     
==========================================
  Files          63       63              
  Lines        4851     4856       +5     
==========================================
+ Hits         3916     3926      +10     
+ Misses        935      930       -5     
Flag Coverage Δ
unittests 80.84% <96.11%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/ontologies_linked_data/serializers/xml.rb 68.96% <0.00%> (ø)
lib/ontologies_linked_data/mappings/mappings.rb 81.81% <97.56%> (-0.13%) ⬇️
lib/ontologies_linked_data/models/base.rb 71.96% <100.00%> (+4.25%) ⬆️
lib/ontologies_linked_data/monkeypatches/object.rb 71.73% <100.00%> (+1.68%) ⬆️
lib/ontologies_linked_data/serializers/json.rb 80.88% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant