Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solr v8 schema update #177

Closed
wants to merge 2 commits into from
Closed

Solr v8 schema update #177

wants to merge 2 commits into from

Conversation

alexskr
Copy link
Member

@alexskr alexskr commented Nov 14, 2023

update solr schema to be up to date with solr 8.11.2

resolves #121
BioPortal configuration is groupped into one section to make future
upgrades easier.
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9487c7f) 80.78% compared to head (fa7f11e) 80.78%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #177   +/-   ##
========================================
  Coverage    80.78%   80.78%           
========================================
  Files           63       63           
  Lines         4913     4913           
========================================
  Hits          3969     3969           
  Misses         944      944           
Flag Coverage Δ
unittests 80.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexskr alexskr marked this pull request as ready for review November 16, 2023 17:35
@alexskr alexskr requested a review from mdorf November 16, 2023 17:36
Copy link

@syphax-bouazzouni syphax-bouazzouni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I plan to extend our indexation, to add submission and ontology metadata, as acronyms, and descriptions, ... and I wanted just to ask if it is possible to not have the schema.xml files, and just define the schema in the code? this will make it easier to involve and maintain in the future.

Or at least make the schema.xml files more simpler to read, they are too complex and full of things that I have no idea where they come from or what they do.

@mdorf
Copy link
Member

mdorf commented Jan 24, 2024

I plan to extend our indexation, to add submission and ontology metadata, as acronyms, and descriptions, ... and I wanted just to ask if it is possible to not have the schema.xml files, and just define the schema in the code? this will make it easier to involve and maintain in the future.

Or at least make the schema.xml files more simpler to read, they are too complex and full of things that I have no idea where they come from or what they do.

We are also working on changing the schema at the moment to add functionality related to bmir-radx/radx-project#46

@alexskr
Copy link
Member Author

alexskr commented Jan 24, 2024

ditching hardcoded schema.xml in solr in favor of a programmatic solr schema configuration has been in on our mind for quite a long time. (#118)

@syphax-bouazzouni
Copy link

ditching hardcoded schema.xml in solr in favor of a programmatic solr schema configuration has been in on our mind for quite a long time. (#118)

I did a first iteration of that, please see ontoportal-lirmm/goo#54

@alexskr
Copy link
Member Author

alexskr commented Mar 21, 2024

closing in favor of ontoportal-lirmm/goo#54

@alexskr alexskr closed this Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants