Skip to content

Commit

Permalink
Add flag to windows specs to enable rebase
Browse files Browse the repository at this point in the history
Update UMA to generate the rebase targets when the flag is enabled.
Enable the flag in the specs to run rebase IBM sdk only.

Signed-off-by: Violeta Sebe <[email protected]>
  • Loading branch information
vsebe committed Oct 18, 2017
1 parent f035b8d commit b5431c8
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 1 deletion.
4 changes: 4 additions & 0 deletions buildspecs/j9.flags
Original file line number Diff line number Diff line change
Expand Up @@ -2316,4 +2316,8 @@ Pass J9PORT_SIG_OPTIONS_ZOS_USE_CEEHDLR into j9sig_set_options() before the fir
<description>Compile tracegenc and run it to generate tracefiles</description>
<ifRemoved>Run java version of tracegenc</ifRemoved>
</flag>
<flag id="uma_windowsRebase">
<description>This enables the rebase targets generation for windows platforms</description>
<ifRemoved></ifRemoved>
</flag>
</flags>
1 change: 1 addition & 0 deletions buildspecs/win_x86-64.spec
Original file line number Diff line number Diff line change
Expand Up @@ -281,5 +281,6 @@
<flag id="thr_lockNursery" value="true"/>
<flag id="thr_lockReservation" value="true"/>
<flag id="thr_smartDeflation" value="true"/>
<flag id="uma_windowsRebase" value="true"/>
</flags>
</spec>
1 change: 1 addition & 0 deletions buildspecs/win_x86-64_cmprssptrs.spec
Original file line number Diff line number Diff line change
Expand Up @@ -276,5 +276,6 @@
<flag id="thr_lockNursery" value="true"/>
<flag id="thr_lockReservation" value="true"/>
<flag id="thr_smartDeflation" value="true"/>
<flag id="uma_windowsRebase" value="true"/>
</flags>
</spec>
1 change: 1 addition & 0 deletions buildspecs/win_x86.spec
Original file line number Diff line number Diff line change
Expand Up @@ -290,5 +290,6 @@
<flag id="thr_lockNursery" value="true"/>
<flag id="thr_lockReservation" value="true"/>
<flag id="thr_smartDeflation" value="true"/>
<flag id="uma_windowsRebase" value="true"/>
</flags>
</spec>
Original file line number Diff line number Diff line change
Expand Up @@ -549,7 +549,7 @@ void writeSharedLibResourceFile(Artifact artifact) throws UMAException {
public void writeTopLevelTargets(StringBuffer buffer) throws UMAException {
super.writeTopLevelTargets(buffer);

if ( configuration.isFlagSet("build_openj9") ) {
if ( !configuration.isFlagSet("uma_windowsRebase") ) {
// No rebase in openj9 builds
// ReBase.exe has been removed since Windows SDK 8. It could be replaced with "editbin /REBASE":
// e.g.
Expand Down

0 comments on commit b5431c8

Please sign in to comment.