-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error when using stopping_criteria in .generate if remote=True #137
Comments
I'm not getting the error you posted, but instead a maximum recursion error. I need to have a better error for this, but how things work now you can't send arbitrary objects to the server. It has to be one of: You can see this here: https://github.com/ndif-team/nnsight/blob/main/src/nnsight/pydantics/format/types.py |
Hi, sorry I posted the wrong trace, I got a recursion error too 😅 |
So if I understand correctly, as every stopping criteria is a different class inheriting StoppingCriteria it might not be possible for nnsight to support this argument on remote execution ? |
Yeah ndif/nnsight works with a custom serialized format. So it only supports types we explicitly define. Otherwise anyone could execute arbitrary code with arbitrary classes. If StoppingCriteria seems quite useful maybe I could add it. |
Stopping criteria is an abstract class meant to be inherited. If I understand correctly you'd need to manually add a set of class inheriting StoppingCriteria right ? |
Remote execution does not support stopping_criteria right now:
Error trace:
The text was updated successfully, but these errors were encountered: