Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[META] Update near-wallet.js to latest version on all examples #2208

Closed
6 tasks done
gagdiez opened this issue Aug 13, 2024 · 1 comment
Closed
6 tasks done

[META] Update near-wallet.js to latest version on all examples #2208

gagdiez opened this issue Aug 13, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@gagdiez
Copy link
Collaborator

gagdiez commented Aug 13, 2024

All our examples use the same near-wallet file that abstracts away the complexity of using the near-wallet-selector. We need to make sure all canonical examples have the methods used here:

https://github.com/near/near-discovery/blob/develop/src/components/wallet-selector/WalletSelector.ts

Notice that in the examples we use Javascript and JSDocs

@gagdiez gagdiez added the enhancement New feature or request label Aug 13, 2024
@github-project-automation github-project-automation bot moved this to NEW❗ in DevRel Aug 13, 2024
@PiVortex PiVortex moved this from NEW❗ to In Progress 🏗️ in DevRel Aug 19, 2024
@PiVortex PiVortex moved this from In Progress 🏗️ to Shipped 🚀 in DevRel Oct 14, 2024
@PiVortex PiVortex moved this from Shipped 🚀 to In Progress 🏗️ in DevRel Oct 24, 2024
@PiVortex
Copy link
Contributor

@gagdiez I think I should also add ethereum wallets to all examples, but I see you need this project ID. Did you set it up under a near account or your personal, we should probably have all the examples registered in the same place. https://docs.near.org/tools/ethereum-wallets#get-projectid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Status: Done
Development

No branches or pull requests

4 participants