Skip to content
This repository has been archived by the owner on Oct 4, 2024. It is now read-only.

fix: generate-key-using-seed-phrase #1036

Closed
wants to merge 1 commit into from
Closed

fix: generate-key-using-seed-phrase #1036

wants to merge 1 commit into from

Conversation

hanakannzashi
Copy link

fix issue #949

  • The wrong keyStore variable was used before, resulting in two key pair files generated when using near generate-key --seedPhrase="xxx"

* The wrong keyStore variable was used before, resulting in two key pair files generated when using `near generate-key --seedPhrase="xxx"`
@think-in-universe
Copy link
Member

The fix make sense to me. @volovyks

@volovyks
Copy link
Collaborator

volovyks commented Jan 9, 2023

Thank you @hanakannzashi ! It would be great to add a simple test for this change.
And in general, we need to turn on tests from external contributors in this repo. cc @ailisp I think it should be a standard for all repos where we expect contributions, I suppose, all tooling repos.

Related issue: near/near-workspaces-js#200
For some reason I was not able to turn this feature on there.

@hanakannzashi
Copy link
Author

hanakannzashi commented Jan 9, 2023

Thank you @hanakannzashi ! It would be great to add a simple test for this change. And in general, we need to turn on tests from external contributors in this repo. cc @ailisp I think it should be a standard for all repos where we expect contributions, I suppose, all tooling repos.

Related issue: near/workspaces-js#200 For some reason I was not able to turn this feature on there.

This PR still has some issue, I will close it later. I am not particularly clear about the purpose of MergeKeyStore in this project. The code of generate-key.js is very strange, I think there are many issues in this file. Also, I can't unstand the code on seed-phrase.js

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants