Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Borsh Serializers #2167

Closed
2 of 4 tasks
MaksymZavershynskyi opened this issue Feb 21, 2020 · 7 comments
Closed
2 of 4 tasks

Cleanup Borsh Serializers #2167

MaksymZavershynskyi opened this issue Feb 21, 2020 · 7 comments
Assignees
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. C-epic Category: an epic P-high Priority: High

Comments

@MaksymZavershynskyi
Copy link
Contributor

MaksymZavershynskyi commented Feb 21, 2020

@MaksymZavershynskyi MaksymZavershynskyi added C-enhancement Category: An issue proposing an enhancement or a PR with one. P-high Priority: High C-epic Category: an epic labels Feb 21, 2020
@ghost
Copy link

ghost commented Feb 21, 2020

Never liked cabbage, until I ate borsh.

Question is if this naming-indirection makes sense. I mean, reading technical docs and getting hungry, and guessing what this library does?

Possibly you should consider giving "borsh" a more expressive name, something that implies what this library does.

near-stream?

@MaksymZavershynskyi
Copy link
Contributor Author

Never liked cabbage, until I ate borsh.

Question is if this naming-indirection makes sense. I mean, reading technical docs and getting hungry, and guessing what this library does?

Possibly you should consider giving "borsh" a more expressive name, something that implies what this library does.

near-stream?

Borsh name is too much ingrained into our codebase to be easily switched. Also, similar to CBOR, BORSH is a meaningful abbreviation see http://borsh.io/

@MaksymZavershynskyi MaksymZavershynskyi changed the title Full Borsh support in the API Cleanup Borsh Serializers Mar 10, 2020
@MaksymZavershynskyi
Copy link
Contributor Author

Assigning to @kcole16 since the rest of the work is mostly on the Applayer side.

@ilblackdragon ilblackdragon added this to the MainNet milestone Mar 18, 2020
@ilblackdragon
Copy link
Member

ilblackdragon commented Mar 18, 2020

@nearmax I'm a bit lost given some work was already done - Are the steps left to finish this Epic required for MainNet or not?

@MaksymZavershynskyi MaksymZavershynskyi removed this from the MainNet milestone Mar 21, 2020
@MaksymZavershynskyi
Copy link
Contributor Author

This is not a Mainnet blocker. Since the remaining steps will not change the node API, we will be able to update via nearlib. Moving to the IceBox and removing from the Mainnet release.

@stale
Copy link

stale bot commented Jul 1, 2021

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months.
It will be closed in 7 days if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the S-stale label Jul 1, 2021
@bowenwang1996
Copy link
Collaborator

I believe the majority of the work is done. The rest is tracked in #2242

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. C-epic Category: an epic P-high Priority: High
Projects
None yet
Development

No branches or pull requests

4 participants