Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove default-wallets package from Wallet Selector #1002

Closed
kujtimprenkuSQA opened this issue Nov 7, 2023 · 0 comments · Fixed by #1005
Closed

Remove default-wallets package from Wallet Selector #1002

kujtimprenkuSQA opened this issue Nov 7, 2023 · 0 comments · Fixed by #1005
Assignees
@kujtimprenkuSQA
Labels
Emerging Tech Emerging Tech flying formation at Pagoda

Comments

@kujtimprenkuSQA
Copy link
Contributor

Description

The default wallets package has been deprecated for quite a while and wallet-selector does not publish new versions of this package anymore. This task is about removing the code related to default-wallets package from Wallet Selector because it's not needed in this repo.

The reason why default-wallets was removed:

Pagoda is not in the business of assigning which wallets are defaults. Wallet Selector will not have recommended defaults to support decentralization and give Wallets equal exposure.

Related PRs: #681 , #867
@kujtimprenkuSQA kujtimprenkuSQA added Emerging Tech Emerging Tech flying formation at Pagoda Near BOS labels Nov 7, 2023
@kujtimprenkuSQA kujtimprenkuSQA self-assigned this Nov 7, 2023
@kujtimprenkuSQA kujtimprenkuSQA mentioned this issue Nov 9, 2023
Merged
14 tasks
@kujtimprenkuSQA kujtimprenkuSQA linked a pull request Nov 9, 2023 that will close this issue
chore: Remove default-wallets package #1005
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kujtimprenkuSQA kujtimprenkuSQA

Labels
Emerging Tech Emerging Tech flying formation at Pagoda
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Remove default-wallets package near/wallet-selector
1 participant
@kujtimprenkuSQA