Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Defect] Losing connection after page refresh (here-wallet) #1074

Closed
wpdas opened this issue Feb 8, 2024 · 4 comments
Closed

[Defect] Losing connection after page refresh (here-wallet) #1074

wpdas opened this issue Feb 8, 2024 · 4 comments
Assignees
Labels
bug Something isn't working Emerging Tech Emerging Tech flying formation at Pagoda

Comments

@wpdas
Copy link

wpdas commented Feb 8, 2024

Describe the bug

After connecting my wallet using HERE Wallet, everything works fine until I refresh the page.

I can see a new item herewallet:keystore added to Local Storage storing the account's info, but the Wallet Selector cannot detect it.

It works if I manually add an item to Local Storage like this (MyNearWallet does it automatically):

key: near-api-js:keystore:<account_id>:testnet
value: ed25519:<account_key>

Steps To Reproduce

Steps to reproduce the behavior:

  1. Go to any dApp using Here Wallet
  2. Connect your wallet
  3. Check if you are connected
  4. Refresh the page
  5. Wallet is not connected anymore

Error description

Expected behavior

It is expected that the wallet will still connect.

Desktop:

  • OS : macOS
  • Browser : Chrome / Safari
@wpdas wpdas added bug Something isn't working Emerging Tech Emerging Tech flying formation at Pagoda Near BOS labels Feb 8, 2024
@kujtimprenkuSQA
Copy link
Contributor

kujtimprenkuSQA commented Feb 8, 2024

Hi, thank you for raising this issue.

Just tested it on our guest-book example: https://near.github.io/wallet-selector/ even after page refresh the wallet-selector is still in a signed-in state.

Can you please share the dApp that the issue is happening?

Also just noticed that HERE Wallet iOS app was updated and now I can't sign transactions that require confirmation on the wallet.

@kujtimprenkuSQA kujtimprenkuSQA self-assigned this Feb 8, 2024
@kujtimprenkuSQA
Copy link
Contributor

Just tested it on https://near.org/ and https://near.social/ and it seems to be working on these two dApps.

@wpdas
Copy link
Author

wpdas commented Feb 8, 2024

Hi, thank you for raising this issue.

Just tested it on our guest-book example: https://near.github.io/wallet-selector/ even after page refresh the wallet-selector is still in a signed-in state.

Can you please share the dApp that the issue is happening?

Also just noticed that HERE Wallet iOS app was updated and now I can't sign transactions that require confirmation on the wallet.

Thank you for the quick response. Let me check if this is because of this iOS update situation. I'll do more tests here and also check if this is something on my implementation.

@wpdas
Copy link
Author

wpdas commented Feb 8, 2024

@kujtimprenkuSQA I found the issue. It was something on my dApp. The state to check accounts were being called twice. Sorry for this.

Thank you for your support.

@wpdas wpdas closed this as completed Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Emerging Tech Emerging Tech flying formation at Pagoda
Projects
None yet
Development

No branches or pull requests

2 participants