Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isInstalled check for Near Snap #933

Closed
kujtimprenkuSQA opened this issue Sep 19, 2023 · 0 comments · Fixed by #938
Closed

Add isInstalled check for Near Snap #933

kujtimprenkuSQA opened this issue Sep 19, 2023 · 0 comments · Fixed by #938
Assignees
@erditkurteshiSQA
Labels
bug Something isn't working Emerging Tech Emerging Tech flying formation at Pagoda

Comments

@kujtimprenkuSQA
Copy link
Contributor

kujtimprenkuSQA commented Sep 19, 2023 •
edited
Loading

Describe the bug

If MetaMask Flask is not installed the Near Snap does not show the WalletNotInstalled view in the modal-ui instead it shows an error:

image

To Reproduce
Steps to reproduce the behavior:

  1. Remove/Disable metamask flask
  2. Open the modal
  3. Click on Near Snap option
  4. Error will show instead of "WalletNotInstalled" view.

Expected behavior

  • To keep things consistent with other Injected Wallets we should check if MetaMask Flask is installed and based on it set the value of available in metadata.
  • Near Snap should be hidden on mobile

Expected:

image

Screenshots
If applicable, add screenshots to help explain your problem.

Device (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.
@kujtimprenkuSQA kujtimprenkuSQA added bug Something isn't working Emerging Tech Emerging Tech flying formation at Pagoda Near BOS labels Sep 19, 2023
@erditkurteshiSQA erditkurteshiSQA self-assigned this Sep 21, 2023
@erditkurteshiSQA erditkurteshiSQA mentioned this issue Sep 21, 2023
Merged
14 tasks
@erditkurteshiSQA erditkurteshiSQA linked a pull request Sep 21, 2023 that will close this issue
fix: Added installed and mobile check for near snap #938
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erditkurteshiSQA erditkurteshiSQA

Labels
bug Something isn't working Emerging Tech Emerging Tech flying formation at Pagoda
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Added installed and mobile check for near snap near/wallet-selector
2 participants
@kujtimprenkuSQA @erditkurteshiSQA