Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix Already passed to createRoot() warning #982

Merged
merged 3 commits into from
Oct 23, 2023
Merged

fix: Fix Already passed to createRoot() warning #982

merged 3 commits into from
Oct 23, 2023

Conversation

kujtimprenkuSQA
Copy link
Contributor

@kujtimprenkuSQA kujtimprenkuSQA commented Oct 23, 2023 •
edited
Loading

Description

Closes #980

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Type of change.

  • FIX - a PR of this type patches a bug.
  • FEATURE - a PR of this type introduces a new feature.
  • BUILD - a PR of this type introduces build changes.
  • CI - a PR of this type introduces CI changes.
  • DOCS - a PR of this type introduces DOCS improvement.
  • STYLE - a PR of this type introduces style changes.
  • REFACTOR - a PR of this type introduces refactoring.
  • PERFORMANCE - a PR of this type introduces performance changes.
  • TEST - a PR of this type adds more tests.
  • CHORE - a PR introduces other changes than the specified above.

@kujtimprenkuSQA kujtimprenkuSQA self-assigned this Oct 23, 2023
@kujtimprenkuSQA kujtimprenkuSQA linked an issue Oct 23, 2023 that may be closed by this pull request
[Defect] Already passed to createRoot() #980
Closed
@kujtimprenkuSQA kujtimprenkuSQA marked this pull request as ready for review October 23, 2023 10:48
@github-actions github-actions bot changed the title Fix Already passed to createRoot() warning fix: Fix Already passed to createRoot() warning Oct 23, 2023
@kujtimprenkuSQA kujtimprenkuSQA merged commit fef2585 into dev Oct 23, 2023
12 of 17 checks passed
@kujtimprenkuSQA kujtimprenkuSQA deleted the 980-defect-already-passed-to-createroot branch October 23, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erditkurteshiSQA erditkurteshiSQA erditkurteshiSQA approved these changes

@HarisSQA HarisSQA Awaiting requested review from HarisSQA

Assignees

@kujtimprenkuSQA kujtimprenkuSQA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Defect] Already passed to createRoot()
2 participants
@kujtimprenkuSQA @erditkurteshiSQA