Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove release notes related to optic release #236

Closed
wants to merge 2 commits into from

Conversation

sameer-coder
Copy link
Contributor

This PR removes the notes generated by the optic release automation from the changelog.

Closes #219

@sameer-coder sameer-coder requested review from davideroffo and simoneb and removed request for davideroffo January 9, 2023 13:39
Copy link
Contributor

@davideroffo davideroffo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just a comment

Copy link
Member

@simoneb simoneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should go in this direction. We should first figure out why this happens and why it doesn't happen other times. Removing entries manually more or a workaround than a solution.

@sameer-coder
Copy link
Contributor Author

I don't think we should go in this direction. We should first figure out why this happens and why it doesn't happen other times. Removing entries manually more or a workaround than a solution.

I tried to find the actual cause of why it is happening. In my observation, when we call the GitHub API to get release notes, the entry related to the previous release it always there as the last entry. At times it comes back as the first entry or somewhere in the middle which is when it shows up in the changelog. When we send the release notes to GitHub to create a draft release that is when it decides whether to include it or not.

I know this sounds fuzzy but I haven't been able to pin point the exact reason why it is happening since most of it process happens on the GitHub side.

@simoneb
Copy link
Member

simoneb commented Jan 9, 2023

I understand this is confusing, but I would start from comparing places where this didn't happen to places where it happened, to see if we can pinpoint anything different that we may be doing in those repos.

@simoneb
Copy link
Member

simoneb commented Jan 16, 2023

Let's close this PR as per the outcome of the linked issue please

@simoneb simoneb deleted the filter-release-notes branch June 22, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove from the changelog the commit related to the last release
3 participants