-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor error handling #3
Labels
Comments
Also, remove all the html from the log file output. |
nearwood
added a commit
that referenced
this issue
Nov 5, 2019
nearwood
added a commit
that referenced
this issue
Nov 5, 2019
nearwood
added a commit
that referenced
this issue
Nov 5, 2019
nearwood
added a commit
that referenced
this issue
Nov 7, 2019
#40) * Improve parse errors #3, and avoid cache if it fails #31 * add version string to deploy script * Fix confusing getMSQ function name * Update splash * Fix invalid html #37 * Fix linter warnings * Fix invalid HTML * Fix html validation select element * Add img alt text * Add favicon #38 * Add SRI #39 * Add button image, tweak CSS * Fix download header and add download hint #30 * Cleanup header * add async to scripts * Add open graph stuff #35 #36 * Fix async scripts * Header color * Fix travis deploying PRs
nearwood
added a commit
that referenced
this issue
Nov 7, 2019
* Improve parse errors #3, and avoid cache if it fails #31 * add version string to deploy script * Fix confusing getMSQ function name * Update splash * Fix invalid html #37 * Fix linter warnings * Fix invalid HTML * Fix html validation select element * Add img alt text * Add favicon #38 * Add SRI #39 * Add button image, tweak CSS * Fix download header and add download hint #30 * Cleanup header * add async to scripts * Add open graph stuff #35 #36 * Fix async scripts * Header color * Fix travis deploying PRs * Fix deploy hopefully * Fix deploy hopefully * travis ci docs aren't great
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Skip the try catch (unless we expect errors and can continue), and use the error_handler callback for major problems (and send a 500 response, for example).
The text was updated successfully, but these errors were encountered: